Remove references to old sample_texture function #17195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
JMS55
approved these changes
Jan 6, 2025
| // How this is done depends on whether we're rendering meshlets or regular | ||
| // meshes. | ||
| // Biasing info needed to sample from a texture. How this is done depends on | ||
| // whether we're rendering meshlets or regular meshes. | ||
| struct SampleBias { |
There was a problem hiding this comment.
Not for this PR, but as a side note the derivative stuff for meshlet meshes are not biases. We should probably rename this type to TextureSampleInfo in the future or something.
alice-i-cecile
added
C-Docs
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective Remove some outdated docs from 0.15 that mention a removed function. ## Solution In `pbr_functions.wgsl`, I think it's fine to just remove the mention. In `meshlet/asset.rs`, I think it would be nice to still have a note on how texture samples should be done. Unfortunately, there isn't a nice abstraction for it any more. Current workaround, for reference: https://github.com/bevyengine/bevy/blob/b386d08d0f905d07843ddfed936e404845a6a10b/crates/bevy_pbr/src/render/pbr_fragment.wgsl#L184-L208 For now, I've just removed the mention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Remove some outdated docs from 0.15 that mention a removed function.
Solution
In
pbr_functions.wgsl, I think it's fine to just remove the mention. Inmeshlet/asset.rs, I think it would be nice to still have a note on how texture samples should be done. Unfortunately, there isn't a nice abstraction for it any more. Current workaround, for reference:bevy/crates/bevy_pbr/src/render/pbr_fragment.wgsl
Lines 184 to 208 in b386d08
For now, I've just removed the mention.