Refactor FunctionSystem to use a single Option
#16514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDoot
added
A-ECS
benfrankel
reviewed
Nov 26, 2024
| pub(crate) system_meta: SystemMeta, | ||
| world_id: Option<WorldId>, | ||
| state: Option<FunctionSystemState<Marker, F>>, | ||
| system_meta: SystemMeta, | ||
| archetype_generation: ArchetypeGeneration, | ||
| // NOTE: PhantomData<fn()-> T> gives this safe Send/Sync impls | ||
| marker: PhantomData<fn() -> Marker>, |
There was a problem hiding this comment.
Is this PhantomData still needed with Marker now appearing in FunctionSystemState<Marker, F>?
There was a problem hiding this comment.
It no longer appears in FunctionSystemState, so I'm assuming it still needs to exist.
ItsDoot
changed the title
OptionFunctionSystem to use a single Option
benfrankel
approved these changes
Nov 27, 2024
chescock
approved these changes
Nov 27, 2024
chescock
added
S-Ready-For-Final-Review
BenjaminBrienen
approved these changes
Nov 27, 2024
mockersf
approved these changes
Dec 1, 2024
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Dec 2, 2024
# Objective Combine the `Option<_>` state in `FunctionSystem` into a single `Option` to provide clarity and save space. ## Solution Simplifies `FunctionSystem`'s layout by using a single `Option<FunctionSystemState>` for state that must be initialized before running, and saves a byte by removing the need to store an enum tag. Additionally, calling `System::run` on an uninitialized `System` will now give a more descriptive message prior to verifying the `WorldId`. ## Testing Ran CI checks locally.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective Combine the `Option<_>` state in `FunctionSystem` into a single `Option` to provide clarity and save space. ## Solution Simplifies `FunctionSystem`'s layout by using a single `Option<FunctionSystemState>` for state that must be initialized before running, and saves a byte by removing the need to store an enum tag. Additionally, calling `System::run` on an uninitialized `System` will now give a more descriptive message prior to verifying the `WorldId`. ## Testing Ran CI checks locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Combine the
Option<_>state inFunctionSysteminto a singleOptionto provide clarity and save space.Solution
Simplifies
FunctionSystem's layout by using a singleOption<FunctionSystemState>for state that must be initialized before running, and saves a byte by removing the need to store an enum tag. Additionally, callingSystem::runon an uninitializedSystemwill now give a more descriptive message prior to verifying theWorldId.Testing
Ran CI checks locally.