Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic due to malformed mesh in specialized_mesh_pipeline #15899

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix panic due to malformed mesh in specialized_mesh_pipeline #15899

merged 1 commit into from
Oct 15, 2024

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Oct 14, 2024 •
edited
Loading

Objective

Fixes #15891

Solution

Just remove the invalid triangle. I'm assuming that line of code was originally copied from one that was drawing a quad.

Testing

  • cargo run --example specialized_mesh_pipeline
  • hover over over the triangles

Tested on macos

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Oct 14, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Examples An addition or correction to our examples A-Picking Pointing at and selecting objects of all sorts and removed C-Bug An unexpected or incorrect behavior labels Oct 14, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 15, 2024
Merged via the queue into bevyengine:main with commit d17de6c Oct 15, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Picking Pointing at and selecting objects of all sorts A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

specialized_mesh_pipeline example panics when hovering over mesh
2 participants
@rparrett @alice-i-cecile