Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content-type header to BRP HTTP responses #15552

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add content-type header to BRP HTTP responses #15552

merged 1 commit into from
Sep 30, 2024

Conversation

LiamGallagher737
Copy link
Member

This makes HTTP clients like httpie format the response as JSON rather than text for a much nicer experience testing things.

@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Sep 30, 2024
@alice-i-cecile
Copy link
Member

@coreh if you have time, review here would be nice :)

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Dev-Tools Tools used to debug Bevy applications. S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 30, 2024
@djeedai djeedai added D-Trivial Nice and easy! A great choice to get started with Bevy and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 30, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 30, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 30, 2024
Merged via the queue into bevyengine:main with commit 10068f4 Sep 30, 2024
32 checks passed
@coreh
Copy link
Contributor

coreh commented Sep 30, 2024

Already merged, but LGTM! 😆

@LiamGallagher737 LiamGallagher737 deleted the brp-http-content-type branch September 30, 2024 23:32
robtfm pushed a commit to robtfm/bevy that referenced this pull request Oct 4, 2024
@LiamGallagher737 @robtfm
Add content-type header to BRP HTTP responses (bevyengine#15552)
296a8af 
This makes HTTP clients like httpie format the response as JSON rather
than text for a much nicer experience testing things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeedai djeedai djeedai approved these changes

@IceSentry IceSentry IceSentry approved these changes

@mweatherley mweatherley Awaiting requested review from mweatherley

Assignees
No one assigned
Labels
A-Dev-Tools Tools used to debug Bevy applications. C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
5 participants
@LiamGallagher737 @alice-i-cecile @coreh @djeedai @IceSentry