Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transparent_window example on wayland #15262

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Fix transparent_window example on wayland #15262

merged 1 commit into from
Oct 6, 2024

Conversation

mahkoh
Copy link
Contributor

@mahkoh mahkoh commented Sep 17, 2024

Wayland only supports pre-multiplied alpha. Behavior on X11 seems unchanged.

Objective

Solution

  • Request pre-multiplied alpha.

Testing

  • Ran the example locally.

@mahkoh
Fix transparent_window example on wayland
a868959 
Wayland only supports pre-multiplied alpha. Behavior on X11 seems unchanged.
@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@mahkoh
Copy link
Contributor Author

mahkoh commented Sep 17, 2024

Seems to break running with opengl which only supports opaque.

@mnmaita mnmaita added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 17, 2024
@alice-i-cecile
Copy link
Member

I'd prefer to add a toggle between the transparency modes, with a comment about which modes work on which platforms (ideally a link to docs where this information already exists).

@alice-i-cecile alice-i-cecile added A-Windowing Platform-agnostic interface layer to run your app in S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 17, 2024
@mahkoh
Copy link
Contributor Author

mahkoh commented Oct 1, 2024

Seems to break running with opengl which only supports opaque.

If the opengl bavkend doesnt support transparency, then this example not working at all is probably OK.

I'd prefer to add a toggle between the transparency modes, with a comment about which modes work on which platforms

Sounds like a task for a different PR.

@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Oct 1, 2024
@TotalKrill TotalKrill self-assigned this Oct 6, 2024
@TotalKrill
Copy link
Contributor

Looks good to me!

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 6, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 6, 2024
Merged via the queue into bevyengine:main with commit f37f5fd Oct 6, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

@TotalKrill TotalKrill

Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bevy Transparent Window not working
4 participants
@mahkoh @alice-i-cecile @TotalKrill @mnmaita