-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix floating point math #15239
Fix floating point math #15239
Conversation
This is incomplete because the test still fails :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -ln
needs fixing, I left some other comments, but those aren't all that blocking.
Someone else please take a thorough look, cause there's a lot of code touched so I may have missed smth.
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
…Brienen/bevy into fix-floating-point-math
This is in a good state for now, but I'm waiting for conclusive feedback on exactly how explicit we should make the calls to bevy_math trig functions, especially in documentation and examples. |
If anyone would like to suggest a different name for |
|
Stick it in the prelude, but use only the method names please. |
Oh wow, this ended up being quite an undertaking, props for the work. |
Objective
bevy_color
's operations are not stable across all hardware due to use of trigonometric float methods #15236Solution
Testing
Did you test these changes? If so, how?
Unit tests and
cargo run -p ci -- test
How can other people (reviewers) test your changes? Is there anything specific they need to know?
Execute
cargo run -p ci -- test
on Windows.If relevant, what platforms did you test these changes on, and are there any important ones you can't test?
Windows
Migration Guide