Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating point math #15239

Merged
merged 44 commits into from
Sep 16, 2024
Merged

Fix floating point math #15239

Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
c219f67
add disallowed-methods
BenjaminBrienen Sep 15, 2024
a2c4901
use bevy::math for floating point ops
BenjaminBrienen Sep 15, 2024
9e9ee01
Merge branch 'main' into fix-floating-point-math
BenjaminBrienen Sep 15, 2024
a5a176c
fmt
BenjaminBrienen Sep 15, 2024
7ff7087
missed one
BenjaminBrienen Sep 15, 2024
faffec6
fmt
BenjaminBrienen Sep 15, 2024
bdbe8a1
missed a couple more
BenjaminBrienen Sep 15, 2024
0d31548
fmt
BenjaminBrienen Sep 15, 2024
94de372
missing use
BenjaminBrienen Sep 15, 2024
21a260a
fix doc and fmt
BenjaminBrienen Sep 15, 2024
8345218
fix more
BenjaminBrienen Sep 15, 2024
c10b378
add use
BenjaminBrienen Sep 15, 2024
448c691
fmt
BenjaminBrienen Sep 16, 2024
388f7ec
anisotropy
BenjaminBrienen Sep 16, 2024
c624896
more
BenjaminBrienen Sep 16, 2024
12a2467
fix
BenjaminBrienen Sep 16, 2024
c107ecd
many_lights
BenjaminBrienen Sep 16, 2024
0174518
feedback from PR review
BenjaminBrienen Sep 16, 2024
6fd9ffa
more feedback from pr
BenjaminBrienen Sep 16, 2024
6ac57a8
more feedback
BenjaminBrienen Sep 16, 2024
b8d1cb9
remove use
BenjaminBrienen Sep 16, 2024
0e4cb26
undo change
BenjaminBrienen Sep 16, 2024
154fb9c
lib default
BenjaminBrienen Sep 16, 2024
6464451
Revert default libm feature
alice-i-cecile Sep 16, 2024
06ffd42
Update crates/bevy_gizmos/src/arcs.rs
BenjaminBrienen Sep 16, 2024
c8e309e
Update crates/bevy_render/src/mesh/primitives/dim3/capsule.rs
BenjaminBrienen Sep 16, 2024
2583494
Update crates/bevy_render/src/mesh/primitives/dim3/capsule.rs
BenjaminBrienen Sep 16, 2024
8d4b77b
Update crates/bevy_color/src/lcha.rs
BenjaminBrienen Sep 16, 2024
8abaf9f
Update crates/bevy_color/src/oklcha.rs
BenjaminBrienen Sep 16, 2024
9f25494
Update crates/bevy_pbr/src/pbr_material.rs
BenjaminBrienen Sep 16, 2024
b1e93bc
feedback from PR
BenjaminBrienen Sep 16, 2024
1224f68
Merge branch 'fix-floating-point-math' of https://github.com/Benjamin…
BenjaminBrienen Sep 16, 2024
6e29c7e
fmt
BenjaminBrienen Sep 16, 2024
4ab5679
add ops to prelude and use it explicitly
BenjaminBrienen Sep 16, 2024
33e5ed5
fmt
BenjaminBrienen Sep 16, 2024
9397361
fix unresolved import
BenjaminBrienen Sep 16, 2024
1b2888f
use
BenjaminBrienen Sep 16, 2024
1cd83d8
fmt again ???
BenjaminBrienen Sep 16, 2024
ac4e530
fix
BenjaminBrienen Sep 16, 2024
61efa14
cleanup
BenjaminBrienen Sep 16, 2024
bdb9471
fmt
BenjaminBrienen Sep 16, 2024
ed55369
fix example
BenjaminBrienen Sep 16, 2024
8a55050
fix more examples
BenjaminBrienen Sep 16, 2024
951bce8
fmt
BenjaminBrienen Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
@BenjaminBrienen
BenjaminBrienen committed Sep 15, 2024
commit faffec6d3f1eb6c94457bd0d7dbe772dd31dee87
2 changes: 1 addition & 1 deletion crates/bevy_pbr/src/meshlet/visibility_buffer_raster_node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ impl Node for MeshletVisibilityBufferRasterPassNode {
.fetch_and(false, Ordering::SeqCst);

let thread_per_cluster_workgroups =
cbrt((meshlet_view_resources.scene_cluster_count.div_ceil(128) as f32)).ceil() as u32;
cbrt(meshlet_view_resources.scene_cluster_count.div_ceil(128) as f32).ceil() as u32;

render_context
.command_encoder()
Expand Down
Loading