Resolve UI outlines using the correct target's viewport size #14947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `ui_layout_system` instead. * Resolve outlines using the target's viewport size, instead of always using the size of the `PrimaryWindow`.
ickshonpe
changed the title
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Aug 27, 2024
|
Not sure why the CI is failing with all those system ordering amibiguities. |
The CI is difficult to parse, you need to look for systems you specifically touched. |
|
Yeah, I'm not thrilled with the output, but if the net effect is a decrease in ambiguities just set the expected number to the new total. |
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Sep 5, 2024
`resolve_outlines_system` wasn't updated when multi-window support was added and it always uses the size of the primary window when resolving viewport coords, regardless of the layout's camera target. Fixes #14945 It's awkward to get the viewport size of the target for an individual node without walking the tree or adding extra fields to `Node`, so I removed `resolve_outlines_system` and instead the outline values are updated in `ui_layout_system`. --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
resolve_outlines_systemwasn't updated when multi-window support was added and it always uses the size of the primary window when resolving viewport coords, regardless of the layout's camera target.Fixes #14945
Solution
It's awkward to get the viewport size of the target for an individual node without walking the tree or adding extra fields to
Node, so I removedresolve_outlines_systemand instead the outline values are updated inui_layout_system.