Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve UI outlines using the correct target's viewport size #14947

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Resolve UI outlines using the correct target's viewport size #14947

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2126287
* Removed `resolve_outlines_system`, outline geometry is calculated i…
ickshonpe Aug 27, 2024
00618d6
Removed `UiSystem::Outlines` variant.
ickshonpe Aug 28, 2024
9409c4d
Merge branch 'main' into outlines-fix
ickshonpe Aug 28, 2024
c377731
Merge branch 'main' into outlines-fix
alice-i-cecile Aug 28, 2024
383d0d9
update system ambiguity count
ickshonpe Sep 1, 2024
f78435d
updated ambiguity count
ickshonpe Sep 1, 2024
34c2504
Merge branch 'main' into outlines-fix
alice-i-cecile Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed UiSystem::Outlines variant.
  • Loading branch information
@ickshonpe
ickshonpe committed Aug 28, 2024
commit 00618d660220dc0e33687b70b8b921796f73d75a
6 changes: 1 addition & 5 deletions crates/bevy_ui/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ pub enum UiSystem {
///
/// Runs in [`PostUpdate`].
Stack,
/// After this label, node outline widths have been updated.
///
/// Runs in [`PostUpdate`].
Outlines,
}

/// The current scale of the UI.
Expand Down Expand Up @@ -153,7 +149,7 @@ impl Plugin for UiPlugin {
CameraUpdateSystem,
UiSystem::Prepare.before(UiSystem::Stack),
UiSystem::Layout,
(UiSystem::PostLayout, UiSystem::Outlines),
UiSystem::PostLayout,
)
.chain(),
)
Expand Down