Skip to content

Add entity .trigger() methods #14752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 15, 2024
Merged

Add entity .trigger() methods #14752

merged 4 commits into from
Aug 15, 2024

Conversation

benfrankel
Copy link
Contributor

Objective

Fix #14233.

Solution

Add EntityCommands::trigger and EntityWorldMut::trigger.

Testing

  • Not tested.

@mnmaita mnmaita added C-Feature A new feature, making something new possible A-ECS Entities, components, systems, and events S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 15, 2024
janhohenheim
janhohenheim approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@janhohenheim janhohenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix for holes in our API. Thanks!

@janhohenheim janhohenheim added the D-Trivial Nice and easy! A great choice to get started with Bevy label Aug 15, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 15, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 15, 2024
Merged via the queue into bevyengine:main with commit d849941 Aug 15, 2024
31 checks passed
@benfrankel benfrankel deleted the trigger branch August 15, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@janhohenheim janhohenheim janhohenheim approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support EntityCommands::trigger and EntityWorldMut::trigger
4 participants
@benfrankel @alice-i-cecile @janhohenheim @mnmaita