Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled usage of the POLYGON_MODE_LINE gpu feature in the examples #14402

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Disabled usage of the POLYGON_MODE_LINE gpu feature in the examples #14402

merged 6 commits into from
Jul 29, 2024

Conversation

SarthakSingh31
Copy link
Contributor

Fixes #14353
Fixes #14371

@janhohenheim janhohenheim added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward O-Web Specific to web (WASM) builds labels Jul 20, 2024
@mockersf
Copy link
Member

Could you also update the 2d_shapes example?

mockersf
mockersf reviewed Jul 20, 2024
View reviewed changes
examples/3d/3d_shapes.rs Outdated Show resolved Hide resolved
@SarthakSingh31
Copy link
Contributor Author

SarthakSingh31 commented Jul 22, 2024 •
edited
Loading

Could you also update the 2d_shapes example?

Updated

mockersf
mockersf approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment to the 2d_shapes and 3d_shapes examples explaining that wireframe doesn't work in Wasm?

@mockersf
Copy link
Member

thanks!

@mockersf mockersf added this to the 0.14.1 milestone Jul 23, 2024
BD103
BD103 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have one non-blocking request to add a comment, but no worries if you don't get around to it :)

Cargo.toml Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 29, 2024
@alice-i-cecile @BD103
Explain why the example isn't run on web
19937f9 
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 29, 2024
Merged via the queue into bevyengine:main with commit a9f4fd8 Jul 29, 2024
30 checks passed
@SarthakSingh31 SarthakSingh31 deleted the sar/no-poly-line branch July 31, 2024 16:28
mockersf pushed a commit that referenced this pull request Aug 2, 2024
@SarthakSingh31 @alice-i-cecile
@BD103 @mockersf
Disabled usage of the POLYGON_MODE_LINE gpu feature in the examples (#…
0886e6a 
…14402)

Fixes #14353
Fixes #14371

---------

Signed-off-by: Sarthak Singh <sarthak.singh99@gmail.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.

3d shapes web example crashes when enabling wireframes 3D line example broken on web
5 participants
@SarthakSingh31 @mockersf @BD103 @alice-i-cecile @janhohenheim