-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled usage of the POLYGON_MODE_LINE gpu feature in the examples #14402
Disabled usage of the POLYGON_MODE_LINE gpu feature in the examples #14402
Conversation
Could you also update the 2d_shapes example? |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment to the 2d_shapes and 3d_shapes examples explaining that wireframe doesn't work in Wasm?
Signed-off-by: Sarthak Singh <sarthak.singh99@gmail.com>
8cb179f
to
126d2c1
Compare
thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have one non-blocking request to add a comment, but no worries if you don't get around to it :)
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Fixes #14353
Fixes #14371