Add Triangle3d / Tetrahedron to render_primitives example - #13504
Merged
alice-i-cecile merged 1 commit intoMay 25, 2024
Conversation
mweatherley
added
C-Feature
alice-i-cecile
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
May 25, 2024
| @@ -626,7 +648,7 @@ fn draw_gizmos_3d(mut gizmos: Gizmos, state: Res<State<PrimitiveSelected>>, time | |||
| .resolution(resolution), | |||
| ), | |||
| PrimitiveSelected::Ellipse => {} | |||
Member
There was a problem hiding this comment.
It looks like Ellipse was missed.
Contributor
Author
There was a problem hiding this comment.
I think ellipses are only missing from 3d gizmos and meshes, where the more natural thing would be ellipsoids (paralleling circle/sphere), which we don't have yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This is just cleanup; we've got some more renderable gizmos and primitives now that hadn't been added to this example, so let's add them.
Solution
In the
render_primitivesexample:Triangle3dmeshprimitive_3dgizmo impl forTriangle3dand added the gizmoTetrahedronmesh and gizmoI also made the 2d triangle bigger, since it was really small.
Testing
You can just run the example to see that everything turned out all right.
Other
Feel free to let me know if there are other primitives that I missed; I'm happy to tack them onto this PR.