-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chain in breakout example #10124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this example needs the comments but the change is definitely worth doing either way
I’m new to Bevy and the comments in examples help so I would be for it. |
My point was more that these things should be taught somewhere else like the ecs_guide example. We can't teach the concept of |
In fact (as you probably already knew) that example already talks about chain so seems unnecessary for this PR then doesn’t it. Thanks for entertaining my comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On board with the move to .chain above: that logical ordering is correct and it's a nice clean way to express it. I think we should cut the second comment though.
# Objective - We should encourage of the simpler to reason about chain. ## Solution - Use it in the breakout example --- ## Changelog - Switch breakout to use `chain` instead of `before` and `after`
# Objective - We should encourage of the simpler to reason about chain. ## Solution - Use it in the breakout example --- ## Changelog - Switch breakout to use `chain` instead of `before` and `after`
Objective
Solution
Changelog
chain
instead ofbefore
andafter