Release #2416
Merged
Release #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0bcc887.
…cking on the overlay (#2185)
…2309) * All newly created applications now have a default published state. * Added a test case to assert a new application comes up with default published states for both application and the default page. * Function name changed. * When trying to fetch a published version of a page when the page has not been published, throw a 404. * WIP : Not working
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1. - [Release notes](https://github.com/mikaelbr/node-notifier/releases) - [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md) - [Commits](mikaelbr/node-notifier@v8.0.0...v8.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1. Test that when a query is attempted to run on mongodb server but refused because of lack of authorization, then also, it indicates a successful connection establishment.
…a to ensure that we are catching any and all leaks that may be occuring with hikari. (#2374)
…r is the order in which the pages were created and added to the application). This should : (#2391) 1. Get rid of cypress test failures which asserts a certain order till the cypress test case is fixed and unblocks the frontend team. 2. Uses a bulk API to fetch all the pages instead of fetching each page sequentially over different network calls with the database.
* Invite users once triggered should not be cancellable.
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
…ecomes unusable. Symptomatic relief till I can solve for this at leisure over the next few days. Note : Update/Insert are leading to connection leak
trishaanand
previously approved these changes
Jan 4, 2021
* updated assertion * review comment incoirporated Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.