Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup cancelled requests #2387

Merged
merged 8 commits into from
Dec 30, 2020
Merged

Cleanup cancelled requests #2387

merged 8 commits into from
Dec 30, 2020

Conversation

ofpiyush
Copy link
Contributor

@ofpiyush ofpiyush commented Dec 29, 2020 •
edited
Loading

Description

  • Wait for shutdown to complete before letting new requests queue up.
  • use finally to cleanup cancelled request channels

Fixes #2386

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added tests for saga cancel.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ofpiyush ofpiyush requested a review from hetunandu December 29, 2020 08:39
hetunandu
hetunandu previously approved these changes Dec 29, 2020
View reviewed changes
@ofpiyush ofpiyush changed the title Hotfix worker.start call Cleanup cancelled requests Dec 29, 2020
@ofpiyush ofpiyush requested a review from hetunandu December 29, 2020 18:22
@ofpiyush ofpiyush merged commit 3d7242d into release Dec 30, 2020
@ofpiyush ofpiyush deleted the fix/worker_startup branch December 30, 2020 13:26
nidhi-nair pushed a commit that referenced this pull request Jan 5, 2021
@ofpiyush @nidhi-nair
Cleanup cancelled requests (#2387)
8d62a07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hetunandu hetunandu hetunandu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Every alternate app create stalls
2 participants
@ofpiyush @hetunandu