[Worker] Fix critical issues #2393

hetunandu · 2020-12-29T16:27:04Z

Description

Workers cannot clone objects with functions in them. Parsing any object to remove any possible function in them
Confirm object before using the in operator

Fixes #2288
Fixes #2367

app/client/src/workers/evaluation.worker.ts

app/client/src/sagas/evaluationsSaga.ts

Parse all objects to remove functions

829ed8f

hetunandu requested a review from ofpiyush December 29, 2020 16:27

hetunandu added the Bug Something isn't working label Dec 29, 2020

ofpiyush previously approved these changes Dec 29, 2020

View reviewed changes

Check for object before using the in operator

e3ce750

hetunandu dismissed ofpiyush’s stale review via e3ce750 December 29, 2020 16:57

hetunandu changed the title ~~[Worker] Parse all objects to remove functions~~ [Worker] Fix critical issues Dec 29, 2020

hetunandu requested a review from ofpiyush December 29, 2020 17:42

ofpiyush reviewed Dec 29, 2020

View reviewed changes

app/client/src/workers/evaluation.worker.ts Outdated Show resolved Hide resolved

hetunandu added 2 commits December 30, 2020 12:40

Safety plus better typescript

331c480

Capture on sentry

2315d64

hetunandu requested a review from ofpiyush December 30, 2020 08:29

ofpiyush reviewed Dec 30, 2020

View reviewed changes

app/client/src/sagas/evaluationsSaga.ts Show resolved Hide resolved

ofpiyush approved these changes Dec 30, 2020

View reviewed changes

hetunandu merged commit 31d8c8c into release Dec 30, 2020

hetunandu deleted the fix/data-clone-error branch December 30, 2020 12:58

nidhi-nair pushed a commit that referenced this pull request Jan 5, 2021

[Worker] Fix critical issues (#2393)

548efce