Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test #2390

Merged
merged 1 commit into from
Dec 29, 2020
Merged

fix test #2390

merged 1 commit into from
Dec 29, 2020

Conversation

rishabhsaxena
Copy link
Contributor

Description

This test wasn't working properly, it ensures we expand only collapsed menus to validate if the menu item is present

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rishabhsaxena rishabhsaxena merged commit 13fae1a into release Dec 29, 2020
@rishabhsaxena rishabhsaxena deleted the fix-clone-test branch December 29, 2020 12:15
nidhi-nair pushed a commit that referenced this pull request Jan 5, 2021
@rishabhsaxena @nidhi-nair
fix test (#2390)
543a2d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsartisan jsartisan jsartisan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishabhsaxena @jsartisan