Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stacking order of popover and app header #2338

Merged
merged 7 commits into from
Dec 30, 2020
Merged

fix stacking order of popover and app header #2338

merged 7 commits into from
Dec 30, 2020

Conversation

rishabhsaxena
Copy link
Contributor

@rishabhsaxena rishabhsaxena commented Dec 23, 2020 •
edited
Loading

Description

Mount header as a sibling of popovers
fixes #2333

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rishabhsaxena rishabhsaxena merged commit 6dd97a6 into release Dec 30, 2020
@rishabhsaxena rishabhsaxena deleted the stack-header-higher-than-popover branch December 30, 2020 09:06
nidhi-nair pushed a commit that referenced this pull request Jan 5, 2021
@rishabhsaxena @nidhi-nair
fix stacking order of popover and app header (#2338)
69acbc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riodeuno riodeuno riodeuno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Popovers' stacking context is greater than the header
2 participants
@rishabhsaxena @riodeuno