Invite users once triggered should not be cancellable. #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanarpit
previously approved these changes
Dec 30, 2020
mohanarpit
approved these changes
Dec 30, 2020
nidhi-nair
pushed a commit
that referenced
this pull request
Jan 5, 2021
* Invite users once triggered should not be cancellable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once the invite flow gets triggered, the client should not be able to cancel this flow. To achieve this, we use a synchronous sink which ignores cancellation.
Fixes #2395
How Has This Been Tested?
Added a test case which cancels the invite flow in 5 ms and asserts that the invite was successful.