Reducing the probability of getting pages out of order (Expected orde… #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r is the order in which the pages were created and added to the application). This should : 1. Get rid of cypress test failures which asserts a certain order till the cypress test case is fixed and unblocks the frontend team. 2. Uses a bulk API to fetch all the pages instead of fetching each page sequentially over different network calls with the database.
|
We should add the order instead |
mohanarpit
approved these changes
Dec 29, 2020
Order requires a proper solution. This was a performance optimization which also temporarily fixes the new failure seen in cypress. @rishabhsaxena is working on the correct fix for the same cypress test failure. Basically pushing this out more because of the performance optimization and the side effect is that the new flakiness reduces till Rishabh fixes it. |
nidhi-nair
pushed a commit
that referenced
this pull request
Jan 5, 2021
…r is the order in which the pages were created and added to the application). This should : (#2391) 1. Get rid of cypress test failures which asserts a certain order till the cypress test case is fixed and unblocks the frontend team. 2. Uses a bulk API to fetch all the pages instead of fetching each page sequentially over different network calls with the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r is the order in which the pages were created and added to the application). This should :