go-algorand 2.9.0-beta #2670
Merged
go-algorand 2.9.0-beta #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a comment about deleted accounts in AccountDeltas
The current code would not pass the `DisableNetworking` flag to the network package. This could be worked around by adding the `DisableNetworking` to the `config.json` file, or with this fix.
The [ineffassign](https://github.com/gordonklaus/ineffassign) linter is in the default set of linters enabled by golangci-lint but wasn't added in #2523 because it was reporting issues. It's also one of the least objectionable linters; ineffectual assignments are rarely intentional and can point out bugs related to assumptions that a variable assignment had some effect. There were various fixes here but I'm not sure if all the changes to remove or fix ineffectual assignments were the right ones.
CircleCI VMs come pre-installed with homebrew and some of the taps and packages we need already set up, so skipping running update and tap and install for those pre-existing assets reduces each job by ~6 minutes each (x 4 jobs).
While working on the agreement package, I noticed the wrong messageEvent type was being used in TestVoteAggregatorBundles (voteVerified instead of a bundleVerified). This leads voteAggregator to use filterVote instead of filterBundle, and read the empty `messageEvent.Input.Vote` value (with round/period/step of 0/0/0) rather than the value of `messageEvent.Input.Bundle` that has the correct RPS and bundle of votes. This leads the events to be thrown away as from an old round instead of being processed by dispatch.
Remove msgp 1.1.47 from go.mod/go.sum files
go-algorand 2.8.0-stable
As #1699 demonstrates, api v2 uses `JSONHandle` that incorrectly encodes maps with numeric fields. Switching to `JSONStrictHandle` fixes the issue since it was specially created for this purpose.
Fix for updating an application with extra program pages
There is now a single package for both centos 7 & 8.
Add report line about txn pool fullness.
`txnpool({lowest reading}, {min(node mean txn pool size)}, {mean(node mean txnpool size)}, {max(node mean txnpool size)}, {highest reading})`
For a test running across 20 nodes, each node has a `node mean txn pool size` across a 20 minute test time. The above line reports the min/avg/max of those txn pool average sizes, and also the lowest and highest txn pool size seen at any moment.
This PR adds two opcodes. cover: "remove top of stack, and place it down the stack such that N elements are above it", uncover: "remove the value at depth N in the stack and shift above items down so the Nth deep value is on top of the stack"
Gauge that didn't change used to disappear from results; this could make a non-zero value appear zero, confusing metrics. gaugeCommon.go split was confusing, merge back into gauge.go
#2645) Since #2527, when you run msgp-generated tests that call `protocol.RunEncodingTest` from a cwd that doesn't contain "go-algorand" in the name and with GOPATH not set, the test may fail due to `//msgp:allocbound` not being read from the source, leading to "msgp: length overflow" errors (test data exceeding the allocbound).
Parameterize no_output_timeout and -short in the general commands on the circle config file to reduce duplicate code.
go-algorand relstable2.8.0-remerge
Add partition to daemon/algod/api/server/router_test.go
Right now a system.json file is not created when setting up systemd through the setup-systemd.sh script. Therefore, users aren't letting their nodes know that the algod process will be managed with systemd. This change modifies the systemd configuration file to create the system.json file in the data directory.
Add a public `Eval()` function in ledger that Indexer can use. The function accepts a custom protocol config so that Indexer can override it to always get asset close amounts, as opposed to only when the protocol supports it. Closes https://github.com/algorand/go-algorand-internal/issues/1211.
Codecov Report
@@ Coverage Diff @@
## rel/beta #2670 +/- ##
============================================
+ Coverage 46.97% 47.02% +0.05%
============================================
Files 348 350 +2
Lines 55715 55832 +117
============================================
+ Hits 26170 26255 +85
- Misses 26604 26625 +21
- Partials 2941 2952 +11
Continue to review full report at Codecov.
|
bricerisingalgorand
approved these changes
Aug 2, 2021
egieseke
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
This is a maintenance release focused around many test improvements and other optimizations.
Changes
Protocol Upgrade
This release does not contain a protocol upgrade.
Additional Resources