Skip to content

Conversation

@tolikzinovyev
Copy link
Contributor

No description provided.

@tolikzinovyev tolikzinovyev self-assigned this Jul 20, 2021
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a given to me, but sure - lets spell it out.

@codecov-commenter
Copy link

Codecov Report

Merging #2586 (22c8609) into master (c58349e) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2586      +/-   ##
==========================================
- Coverage   46.94%   46.91%   -0.04%     
==========================================
  Files         346      346              
  Lines       55697    55697              
==========================================
- Hits        26147    26128      -19     
- Misses      26603    26617      +14     
- Partials     2947     2952       +5     
Impacted Files Coverage Δ
ledger/ledgercore/statedelta.go 41.66% <ø> (ø)
network/wsPeer.go 72.14% <0.00%> (-2.79%) ⬇️
ledger/blockqueue.go 81.03% <0.00%> (-1.15%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
catchup/service.go 69.01% <0.00%> (-0.79%) ⬇️
ledger/eval.go 76.38% <0.00%> (-0.30%) ⬇️
network/wsNetwork.go 60.73% <0.00%> (ø)
cmd/algoh/blockWatcher.go 77.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c58349e...22c8609. Read the comment docs.

@tolikzinovyev
Copy link
Contributor Author

I can't merge unfortunately. "The base branch restricts merging to authorized users."

@tsachiherman tsachiherman merged commit eeee334 into algorand:master Jul 20, 2021
@tolikzinovyev tolikzinovyev deleted the deleted-acct-comment branch January 6, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants