Skip to content

partition router_test.go #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsachiherman merged 3 commits into from
Jul 29, 2021
Merged

partition router_test.go #2652

tsachiherman merged 3 commits into from
Jul 29, 2021

Conversation

@algobarb
Copy link
Contributor

@algobarb algobarb commented Jul 28, 2021 •
edited
Loading

Summary

Add partition to daemon/algod/api/server/router_test.go

Test Plan

Test on CircleCI via PR.

@algobarb algobarb self-assigned this Jul 28, 2021
winder
winder reviewed Jul 28, 2021
View reviewed changes
winder
winder reviewed Jul 28, 2021
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021 •
edited
Loading

Codecov Report

Merging #2652 (7c0d5e8) into master (434b98f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2652   +/-   ##
=======================================
  Coverage   47.04%   47.04%           
=======================================
  Files         349      349           
  Lines       55814    55814           
=======================================
+ Hits        26256    26257    +1     
+ Misses      26608    26607    -1     
  Partials     2950     2950
Impacted Files Coverage Δ
ledger/acctupdates.go 61.88% <0.00%> (-0.42%) ⬇️
network/wsPeer.go 74.37% <0.00%> (-0.28%) ⬇️
catchup/service.go 69.35% <0.00%> (ø)
ledger/blockqueue.go 85.05% <0.00%> (+4.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434b98f...7c0d5e8. Read the comment docs.

@algobarb algobarb changed the title [CircleCI - WIP] partition router_test.go [CircleCI] partition router_test.go Jul 28, 2021
@algobarb algobarb marked this pull request as ready for review July 28, 2021 20:53
@algobarb algobarb changed the title [CircleCI] partition router_test.go partition router_test.go Jul 28, 2021
egieseke
egieseke approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@egieseke egieseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tsachiherman tsachiherman merged commit d1425f0 into algorand:master Jul 29, 2021
@algobarb algobarb deleted the barbara/routertestpartition branch July 29, 2021 13:22
algojack pushed a commit that referenced this pull request Jul 29, 2021
@algobarb @algojack
partition router_test.go (#2652)
4f447ab 
Add partition to daemon/algod/api/server/router_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bricerisingalgorand bricerisingalgorand Awaiting requested review from bricerisingalgorand

@algojack algojack Awaiting requested review from algojack

@onetechnical onetechnical Awaiting requested review from onetechnical

2 more reviewers

@winder winder winder left review comments

@egieseke egieseke egieseke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@algobarb algobarb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@algobarb @codecov-commenter @winder @egieseke @tsachiherman