codec_tester: use runtime.Caller to search for //msgp:allocbound lines #2645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n certain environments
Contributor
|
I think that you forgot to add the |
tsachiherman
approved these changes
Jul 27, 2021
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
looks good to me. I think that the test-of-a-test is an overkill here, but I guess it helped you to verify the fix..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since #2527, when you run msgp-generated tests that call
protocol.RunEncodingTestfrom a cwd that doesn't contain "go-algorand" in the name and with GOPATH not set, the test may fail due to//msgp:allocboundnot being read from the source, leading to "msgp: length overflow" errors (test data exceeding the allocbound).Test Plan
Adding a new test that fails, then fixing it in a follow-up commit.