Skip to content

test: Perf tests part 1. Basis for multiprocess tests process orchestration. #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 8, 2021
Merged

test: Perf tests part 1. Basis for multiprocess tests process orchestration. #922

merged 24 commits into from
Jul 8, 2021

Conversation

SamuelBellomo
Copy link
Contributor

@SamuelBellomo SamuelBellomo commented Jun 27, 2021 •
edited
Loading

This is the basis for local multiprocess testing.
This allowed creating subsequent perf tests locally without having to worry about real device orchestration.
Plan is to extend this to integrate with CI with real devices afterward.
To test locally, this requires a manual step (menu to build local test player)

Currently writing confluence page on all this to document the flow.

@SamuelBellomo SamuelBellomo mentioned this pull request Jun 27, 2021
Merged
@SamuelBellomo SamuelBellomo marked this pull request as ready for review June 27, 2021 23:43
@SamuelBellomo SamuelBellomo requested a review from 0xFA11 June 27, 2021 23:50
becksebenius-unity
becksebenius-unity reviewed Jun 29, 2021
View reviewed changes
0xFA11
0xFA11 reviewed Jun 29, 2021
View reviewed changes
SamuelBellomo and others added 7 commits July 5, 2021 18:32
@SamuelBellomo
consistent naming
b1656ae
@SamuelBellomo @mattwalsh-unity
Apply suggestions from code review
4ddcd25 
Fixed some typos

Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
@SamuelBellomo
Applying suggestions
55e6853
@SamuelBellomo
Merge branch 'test/multiprocess-tests/orchestration' of github.com:Un…
310a78d 
…ity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/orchestration

* 'test/multiprocess-tests/orchestration' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi:
  Apply suggestions from code review
@SamuelBellomo
should be kept public for following PR
7221712
@0xFA11
Merge branch 'develop' into test/multiprocess-tests/orchestration
a3b98a0
@SamuelBellomo
Merge branch 'test/multiprocess-tests/orchestration' of github.com:Un…
0b37b63 
…ity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/orchestration

* 'test/multiprocess-tests/orchestration' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi:
  feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938)
  fix: reducing log level for noisy log and adding details for developer log (#926)
  feat: users can set authority on network transform programmatically (#868)
  refactor: move NetworkBehaviour update to a separate non-static class (#917)
  test: add utils for multi instance tests (#914)
  test: downgrading testproject to 2020.3.12f1 (#927)
  refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913)
  chore: Change function signature of OnDespawnObject to accept NetworkObject (#928)
  fix: Empty prefab removal (#919)
0xFA11
0xFA11 reviewed Jul 6, 2021
View reviewed changes
0xFA11
0xFA11 reviewed Jul 8, 2021
View reviewed changes
testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/BuildMultiprocessTestPlayer.cs Outdated
Comment on lines 31 to 32
[MenuItem(MultiprocessBaseMenuName+"/Build Test Player in debug mode")]
public static void BuildDebug()
Copy link
Contributor

@0xFA11 0xFA11 Jul 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this similar to Build Settings window (see "Development Build" check there, term is "Development" not "Debug")

Suggested change
[MenuItem(MultiprocessBaseMenuName+"/Build Test Player in debug mode")]
public static void BuildDebug()
[MenuItem(MultiprocessBaseMenuName+"/Build Test Player (Development)")]
public static void BuildDevelopment()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above answer.

SamuelBellomo and others added 10 commits July 8, 2021 10:16
@SamuelBellomo
PR suggestions
ed2519c
@SamuelBellomo @0xFA11
changing root menu
b08561a 
Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
@SamuelBellomo
#
1c9fb6c
@SamuelBellomo @0xFA11
rename test scene
c6d3b4a 
Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
@SamuelBellomo @0xFA11
Update testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/B…
2aa372b 
…uildMultiprocessTestPlayer.cs

Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
@SamuelBellomo
Merge branch 'test/multiprocess-tests/orchestration' of github.com:Un…
3b6bfd8 
…ity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/orchestration

* 'test/multiprocess-tests/orchestration' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi:
  Update testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/BuildMultiprocessTestPlayer.cs
  rename test scene
  changing root menu
  no longer ignore '[Ss]treamingAssets/buildInfo.txt'
  feat: network animator Trigger parameter support (#872)

# Conflicts:
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/BuildMultiprocessTestPlayer.cs
@SamuelBellomo
#
90fffe4
@SamuelBellomo
simpler flow
2c915e9
@SamuelBellomo
fixes
9a3bd9b
@0xFA11
minor touch
49d90b4
@0xFA11 0xFA11 enabled auto-merge (squash) July 8, 2021 21:10
@0xFA11 0xFA11 merged commit d08b84a into develop Jul 8, 2021
@0xFA11 0xFA11 deleted the test/multiprocess-tests/orchestration branch July 8, 2021 21:19
SamuelBellomo added a commit that referenced this pull request Jul 8, 2021
@SamuelBellomo
Merge branch 'develop' into test/multiprocess-tests/base-multiprocess…
f34841f 
…-tests

* develop:
  test: Perf tests part 1. Basis for multiprocess tests process orchestration.  (#922)

# Conflicts:
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/BuildMultiprocessTestPlayer.cs
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/MultiprocessOrchestration.cs
SamuelBellomo added a commit that referenced this pull request Jul 8, 2021
@SamuelBellomo
Merge branch 'test/multiprocess-tests/base-multiprocess-tests' into t…
2fba2c4 
…est/multiprocess-tests/execute-step-in-context

* test/multiprocess-tests/base-multiprocess-tests:
  test: Perf tests part 1. Basis for multiprocess tests process orchestration.  (#922)
SamuelBellomo added a commit that referenced this pull request Jul 8, 2021
@SamuelBellomo
Merge branch 'test/multiprocess-tests/execute-step-in-context' into t…
ffdaeb6 
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  test: Perf tests part 1. Basis for multiprocess tests process orchestration.  (#922)

# Conflicts:
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/BuildMultiprocessTestPlayer.cs
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/MultiprocessOrchestration.cs
SamuelBellomo added a commit that referenced this pull request Jul 8, 2021
@SamuelBellomo
Merge branch 'test/multiprocess-tests/adding-perf-tests-for-spawn' in…
14902c6 
…to test/multiprocess-tests/adding-doc-on-how-to-use

* test/multiprocess-tests/adding-perf-tests-for-spawn:
  test: Perf tests part 1. Basis for multiprocess tests process orchestration.  (#922)
SamuelBellomo added a commit that referenced this pull request Jul 23, 2021
@SamuelBellomo
Merge branch 'develop' into sam/feature/interpolation-for-network-tra…
24231cc 
…nsform

* develop:
  test: Perf tests part 3. Adding ExecuteStepInContext for better test readability (#924)
  test: Perf tests part 2. Adding Test Coordinator and base test class (#923)
  fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)
  test: Perf tests part 1. Basis for multiprocess tests process orchestration.  (#922)
  feat: network animator Trigger parameter support (#872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendoyon bendoyon bendoyon left review comments

@mattwalsh-unity mattwalsh-unity mattwalsh-unity left review comments

@becksebenius-unity becksebenius-unity becksebenius-unity left review comments

@0xFA11 0xFA11 0xFA11 approved these changes

@NoelStephensUnity NoelStephensUnity Awaiting requested review from NoelStephensUnity NoelStephensUnity is a code owner

@seanstolberg-unity seanstolberg-unity Awaiting requested review from seanstolberg-unity

@jeffreyrainy jeffreyrainy Awaiting requested review from jeffreyrainy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SamuelBellomo @0xFA11 @bendoyon @mattwalsh-unity @NoelStephensUnity @becksebenius-unity