test: Perf tests part 2. Adding Test Coordinator and base test class #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: moving orchestration to this branch from test/multiprocess-testing/wip
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: cleanup
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: better name
SamuelBellomo
requested review from
NoelStephensUnity,
seanstolberg-unity,
becksebenius-unity,
jeffreyrainy and
mattwalsh-unity
bendoyon
reviewed
Jun 28, 2021
bendoyon
reviewed
Jun 28, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
Outdated
Show resolved
Hide resolved
bendoyon
reviewed
Jun 28, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
Outdated
Show resolved
Hide resolved
bendoyon
reviewed
Jun 28, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
Outdated
Show resolved
Hide resolved
bendoyon
reviewed
Jun 28, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
Outdated
Show resolved
Hide resolved
Fixed some typos Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
…ity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/orchestration * 'test/multiprocess-tests/orchestration' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi: Apply suggestions from code review
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: Applying suggestions Apply suggestions from code review consistent naming
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: #
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: simpler flow
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: fixes
…-tests * develop: test: Perf tests part 1. Basis for multiprocess tests process orchestration. (#922) # Conflicts: # testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/BuildMultiprocessTestPlayer.cs # testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/MultiprocessOrchestration.cs
0xFA11
reviewed
Jul 8, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/BaseMultiprocessTests.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jul 8, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/BaseMultiprocessTests.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jul 8, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/MultiprocessOrchestration.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jul 8, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jul 8, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jul 8, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jul 8, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jul 8, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinatorTests.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jul 8, 2021
testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinatorTests.cs
Outdated
Show resolved
Hide resolved
0xFA11
approved these changes
Jul 9, 2021
…hub.com:Unity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/base-multiprocess-tests * 'test/multiprocess-tests/base-multiprocess-tests' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi: fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)
SamuelBellomo
added a commit
that referenced
this pull request
Jul 9, 2021
…ontext * develop: test: Perf tests part 2. Adding Test Coordinator and base test class (#923) # Conflicts: # testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
SamuelBellomo
added a commit
that referenced
this pull request
Jul 9, 2021
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: test: Perf tests part 2. Adding Test Coordinator and base test class (#923)
SamuelBellomo
added a commit
that referenced
this pull request
Jul 9, 2021
…to test/multiprocess-tests/adding-doc-on-how-to-use * test/multiprocess-tests/adding-perf-tests-for-spawn: test: Perf tests part 2. Adding Test Coordinator and base test class (#923)
SamuelBellomo
added a commit
that referenced
this pull request
Jul 23, 2021
…nsform * develop: test: Perf tests part 3. Adding ExecuteStepInContext for better test readability (#924) test: Perf tests part 2. Adding Test Coordinator and base test class (#923) fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951) test: Perf tests part 1. Basis for multiprocess tests process orchestration. (#922) feat: network animator Trigger parameter support (#872)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test coordinator.
This is the central communication coordinator for perf tests.
Test runner will have a test coordinator that will act as a server. Tests will create new processes that will also have TestCoordinators. TestCoordinators in these players will automatically connect as a client to the test runner.
Each test can trigger client RPCs from the test runner (server) through the TestCoordinator to execute actions relevant to the perf test.
Clients will send test results to the test runner using server RPCs.
This is further abstracted in Part 3 of this PR with ExecuteStepInContext.
To execute these, use the "Run Selected Tests (-your platform-)" button in editor to execute these tests in separate player locally. That separate player will trigger subsequent process creation.
Each child process will self destroy if idle for too long, making sure we're not leaving process alive for ever.
Currently writing confluence page on all this to document the flow.
This PR includes #922 changes