Skip to content

fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

jeffreyrainy
Copy link
Contributor

…riter.

This source code has Illegal cast some network components To GameObject.
So, fix it to get the GameObject from the component.

Contribution from https://github.com/0vjm3wfw9gqm4j

…riter.

This source code has Illegal cast some network components To GameObject.
So, fix it to get the GameObject from the component.

Contribution from https://github.com/0vjm3wfw9gqm4j
@jeffreyrainy jeffreyrainy requested a review from 0xFA11 July 8, 2021 18:39
@jeffreyrainy
Copy link
Contributor Author

@0vjm3wfw9gqm4j this is the PR for your contribution. Thanks

@jeffreyrainy jeffreyrainy merged commit b2209c2 into develop Jul 8, 2021
@jeffreyrainy jeffreyrainy deleted the fix/fix-invalid-cast-on-network-writer branch July 8, 2021 23:09
SamuelBellomo added a commit that referenced this pull request Jul 9, 2021
…hub.com:Unity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/base-multiprocess-tests

* 'test/multiprocess-tests/base-multiprocess-tests' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi:
  fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)
SamuelBellomo added a commit that referenced this pull request Jul 9, 2021
…est/multiprocess-tests/execute-step-in-context

* test/multiprocess-tests/base-multiprocess-tests:
  fix for automation fail right now
  fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)
SamuelBellomo added a commit that referenced this pull request Jul 9, 2021
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  fix for automation fail right now
  fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)

# Conflicts:
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/MultiprocessOrchestration.cs
SamuelBellomo added a commit that referenced this pull request Jul 9, 2021
…to test/multiprocess-tests/adding-doc-on-how-to-use

* test/multiprocess-tests/adding-perf-tests-for-spawn:
  fix for automation fail right now
  fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)
SamuelBellomo added a commit that referenced this pull request Jul 23, 2021
…nsform

* develop:
  test: Perf tests part 3. Adding ExecuteStepInContext for better test readability (#924)
  test: Perf tests part 2. Adding Test Coordinator and base test class (#923)
  fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)
  test: Perf tests part 1. Basis for multiprocess tests process orchestration.  (#922)
  feat: network animator Trigger parameter support (#872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants