Merge branch 'test/multiprocess-tests/base-multiprocess-tests' into test/multiprocess-tests/execute-step-in-context

* test/multiprocess-tests/base-multiprocess-tests:
  fix for automation fail right now
  fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)

Author: SamuelBellomo

com.unity.multiplayer.mlapi/Runtime/Serialization/NetworkWriter.cs

@@ -210,7 +210,7 @@ public void WriteObjectPacked(object value)
             {
                 if (!((NetworkObject)value).IsSpawned)
                 {
-                    throw new ArgumentException($"{nameof(NetworkWriter)} cannot write {nameof(NetworkObject)} types that are not spawned. {nameof(GameObject)}: {((GameObject)value).name}");
+                    throw new ArgumentException($"{nameof(NetworkWriter)} cannot write {nameof(NetworkObject)} types that are not spawned. {nameof(GameObject)}: {((NetworkObject)value).gameObject.name}");
                 }
 
                 WriteUInt64Packed(((NetworkObject)value).NetworkObjectId);
@@ -220,7 +220,7 @@ public void WriteObjectPacked(object value)
             {
                 if (!((NetworkBehaviour)value).HasNetworkObject || !((NetworkBehaviour)value).NetworkObject.IsSpawned)
                 {
-                    throw new ArgumentException($"{nameof(NetworkWriter)} cannot write {nameof(NetworkBehaviour)} types that are not spawned. {nameof(GameObject)}: {((GameObject)value).name}");
+                    throw new ArgumentException($"{nameof(NetworkWriter)} cannot write {nameof(NetworkBehaviour)} types that are not spawned. {nameof(GameObject)}: {((NetworkBehaviour)value).gameObject.name}");
                 }
 
                 WriteUInt64Packed(((NetworkBehaviour)value).NetworkObjectId);

com.unity.multiplayer.mlapi/Tests/Editor/NetworkSerializerTests.cs

@@ -8,6 +8,29 @@ namespace MLAPI.EditorTests
 {
     public class NetworkSerializerTests
     {
+        [Test]
+        public void SerializeUnspawnedNetworkObject()
+        {
+            var gameObject = new GameObject(nameof(SerializeUnspawnedNetworkObject));
+            var networkObject = gameObject.AddComponent<NetworkObject>();
+
+            try
+            {
+                using (var outStream = PooledNetworkBuffer.Get())
+                using (var outWriter = PooledNetworkWriter.Get(outStream))
+                {
+                    outWriter.WriteObjectPacked(networkObject);
+                }
+
+                // we expect the exception below
+                Assert.Fail();
+            }
+            catch(ArgumentException exception)
+            {
+                Assert.True(exception.Message.IndexOf("NetworkWriter cannot write NetworkObject types that are not spawned") != -1);
+            }
+        }
+
         [Test]
         public void SerializeBool()
         {

testproject/Assets/Tests/Runtime/MultiprocessRuntime/BaseMultiprocessTests.cs

@@ -18,7 +18,7 @@ public abstract class BaseMultiprocessTests
     {
         protected virtual bool m_IsPerformanceTest => true;
 
-        private bool ShouldIgnoreTests => m_IsPerformanceTest && Application.isEditor;
+        private bool ShouldIgnoreTests => m_IsPerformanceTest && Application.isEditor || MultiprocessOrchestration.IsUsingUTR(); // todo remove UTR check once we have proper automation
 
         /// <summary>
         /// Implement this to specify the amount of workers to spawn from your main test runner

testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/MultiprocessOrchestration.cs

@@ -2,6 +2,7 @@
 using System.ComponentModel;
 using System.Diagnostics;
 using System.IO;
+using System.Linq;
 using UnityEngine;
 using Debug = UnityEngine.Debug;
 
@@ -60,4 +61,10 @@ public static void StartWorkerNode()
             throw;
         }
     }
+
+    // todo remove this once we have proper automation
+    public static bool IsUsingUTR()
+    {
+        return Environment.GetCommandLineArgs().Contains("-automated");
+    }
 }