Skip to content

test: add utils for multi instance tests #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2021

Conversation

SamuelBellomo
Copy link
Contributor

Moving boiler plate code to base class. This way, each tests will have a common setup and teardown following multi instance tests.
Didn't touch reparenting tests, since they didn't require a player prefab and didn't seem to suffer from that boilerplate code issue.

@SamuelBellomo SamuelBellomo changed the title Test/adding utils for multi instance tests test: Test/adding utils for multi instance tests Jun 21, 2021
@SamuelBellomo SamuelBellomo marked this pull request as ready for review June 21, 2021 19:52
@SamuelBellomo SamuelBellomo self-assigned this Jun 23, 2021
Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xFA11 0xFA11 changed the title test: Test/adding utils for multi instance tests test: add utils for multi instance tests Jun 28, 2021
@SamuelBellomo SamuelBellomo enabled auto-merge (squash) June 29, 2021 21:43
@SamuelBellomo SamuelBellomo merged commit 0855557 into develop Jun 29, 2021
@SamuelBellomo SamuelBellomo deleted the test/adding-utils-for-multi-instance-tests branch June 29, 2021 21:56
SamuelBellomo added a commit that referenced this pull request Jul 6, 2021
…ity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/orchestration

* 'test/multiprocess-tests/orchestration' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi:
  feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938)
  fix: reducing log level for noisy log and adding details for developer log (#926)
  feat: users can set authority on network transform programmatically (#868)
  refactor: move NetworkBehaviour update to a separate non-static class (#917)
  test: add utils for multi instance tests (#914)
  test: downgrading testproject to 2020.3.12f1 (#927)
  refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913)
  chore: Change function signature of OnDespawnObject to accept NetworkObject (#928)
  fix: Empty prefab removal (#919)
SamuelBellomo added a commit that referenced this pull request Jul 6, 2021
…rocess-tests/base-multiprocess-tests

* test/multiprocess-tests/orchestration:
  feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938)
  fix: reducing log level for noisy log and adding details for developer log (#926)
  feat: users can set authority on network transform programmatically (#868)
  refactor: move NetworkBehaviour update to a separate non-static class (#917)
  test: add utils for multi instance tests (#914)
  test: downgrading testproject to 2020.3.12f1 (#927)
  refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913)
  chore: Change function signature of OnDespawnObject to accept NetworkObject (#928)
  fix: Empty prefab removal (#919)
SamuelBellomo added a commit that referenced this pull request Jul 6, 2021
…est/multiprocess-tests/execute-step-in-context

* test/multiprocess-tests/base-multiprocess-tests:
  feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938)
  fix: reducing log level for noisy log and adding details for developer log (#926)
  feat: users can set authority on network transform programmatically (#868)
  refactor: move NetworkBehaviour update to a separate non-static class (#917)
  test: add utils for multi instance tests (#914)
  test: downgrading testproject to 2020.3.12f1 (#927)
  refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913)
  chore: Change function signature of OnDespawnObject to accept NetworkObject (#928)
  fix: Empty prefab removal (#919)
SamuelBellomo added a commit that referenced this pull request Jul 6, 2021
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938)
  fix: reducing log level for noisy log and adding details for developer log (#926)
  feat: users can set authority on network transform programmatically (#868)
  refactor: move NetworkBehaviour update to a separate non-static class (#917)
  test: add utils for multi instance tests (#914)
  test: downgrading testproject to 2020.3.12f1 (#927)
  refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913)
  chore: Change function signature of OnDespawnObject to accept NetworkObject (#928)
  fix: Empty prefab removal (#919)

# Conflicts:
#	testproject/Packages/manifest.json
SamuelBellomo added a commit that referenced this pull request Jul 6, 2021
…to test/multiprocess-tests/adding-doc-on-how-to-use

* test/multiprocess-tests/adding-perf-tests-for-spawn: (22 commits)
  removing comment and adding something a bit more dynamic
  correct spacing
  fix for unused method better comments adding tests to make sure things don't break
  better exception
  using proper list
  using latest test framework
  rename
  apply rename
  should be kept public for following PR
  naming
  Applying suggestions
  Apply suggestions from code review
  consistent naming
  feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938)
  fix: reducing log level for noisy log and adding details for developer log (#926)
  feat: users can set authority on network transform programmatically (#868)
  refactor: move NetworkBehaviour update to a separate non-static class (#917)
  test: add utils for multi instance tests (#914)
  test: downgrading testproject to 2020.3.12f1 (#927)
  refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants