refactor: move NetworkBehaviour update to a separate non-static class #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Note, this PR is dependant on #914 to be merged first for BaseMultiInstanceTest class) |
0xFA11
reviewed
Jun 23, 2021
0xFA11
changed the title
0xFA11
changed the title
|
I also changed the PR title and prefixed it with "refactor:" instead of "fix:" because even though you think this refactoring would help to fix some issues on the other hand, this PR on its own doesn't necessarily fix/address and issue. but, obviously minor so just my 2-cents. |
jeffreyrainy
approved these changes
Jun 29, 2021
SamuelBellomo
added a commit
that referenced
this pull request
Jul 6, 2021
…ity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/orchestration * 'test/multiprocess-tests/orchestration' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi: feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938) fix: reducing log level for noisy log and adding details for developer log (#926) feat: users can set authority on network transform programmatically (#868) refactor: move NetworkBehaviour update to a separate non-static class (#917) test: add utils for multi instance tests (#914) test: downgrading testproject to 2020.3.12f1 (#927) refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913) chore: Change function signature of OnDespawnObject to accept NetworkObject (#928) fix: Empty prefab removal (#919)
SamuelBellomo
added a commit
that referenced
this pull request
Jul 6, 2021
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938) fix: reducing log level for noisy log and adding details for developer log (#926) feat: users can set authority on network transform programmatically (#868) refactor: move NetworkBehaviour update to a separate non-static class (#917) test: add utils for multi instance tests (#914) test: downgrading testproject to 2020.3.12f1 (#927) refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913) chore: Change function signature of OnDespawnObject to accept NetworkObject (#928) fix: Empty prefab removal (#919)
SamuelBellomo
added a commit
that referenced
this pull request
Jul 6, 2021
…est/multiprocess-tests/execute-step-in-context * test/multiprocess-tests/base-multiprocess-tests: feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938) fix: reducing log level for noisy log and adding details for developer log (#926) feat: users can set authority on network transform programmatically (#868) refactor: move NetworkBehaviour update to a separate non-static class (#917) test: add utils for multi instance tests (#914) test: downgrading testproject to 2020.3.12f1 (#927) refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913) chore: Change function signature of OnDespawnObject to accept NetworkObject (#928) fix: Empty prefab removal (#919)
SamuelBellomo
added a commit
that referenced
this pull request
Jul 6, 2021
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938) fix: reducing log level for noisy log and adding details for developer log (#926) feat: users can set authority on network transform programmatically (#868) refactor: move NetworkBehaviour update to a separate non-static class (#917) test: add utils for multi instance tests (#914) test: downgrading testproject to 2020.3.12f1 (#927) refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913) chore: Change function signature of OnDespawnObject to accept NetworkObject (#928) fix: Empty prefab removal (#919) # Conflicts: # testproject/Packages/manifest.json
SamuelBellomo
added a commit
that referenced
this pull request
Jul 6, 2021
…to test/multiprocess-tests/adding-doc-on-how-to-use * test/multiprocess-tests/adding-perf-tests-for-spawn: (22 commits) removing comment and adding something a bit more dynamic correct spacing fix for unused method better comments adding tests to make sure things don't break better exception using proper list using latest test framework rename apply rename should be kept public for following PR naming Applying suggestions Apply suggestions from code review consistent naming feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938) fix: reducing log level for noisy log and adding details for developer log (#926) feat: users can set authority on network transform programmatically (#868) refactor: move NetworkBehaviour update to a separate non-static class (#917) test: add utils for multi instance tests (#914) test: downgrading testproject to 2020.3.12f1 (#927) refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behaviour update was static and made multiinstance tests flaky. Moving this to its own separate component on NetworkManager solves this.
This PR also adds a first pass at tests for NetworkBehaviourUpdater.