fix: Empty prefab removal on init #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LukeStampfli
approved these changes
Jun 28, 2021
jlao
changed the title
SamuelBellomo
added a commit
that referenced
this pull request
Jul 6, 2021
…ity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/orchestration * 'test/multiprocess-tests/orchestration' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi: feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938) fix: reducing log level for noisy log and adding details for developer log (#926) feat: users can set authority on network transform programmatically (#868) refactor: move NetworkBehaviour update to a separate non-static class (#917) test: add utils for multi instance tests (#914) test: downgrading testproject to 2020.3.12f1 (#927) refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913) chore: Change function signature of OnDespawnObject to accept NetworkObject (#928) fix: Empty prefab removal (#919)
SamuelBellomo
added a commit
that referenced
this pull request
Jul 6, 2021
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938) fix: reducing log level for noisy log and adding details for developer log (#926) feat: users can set authority on network transform programmatically (#868) refactor: move NetworkBehaviour update to a separate non-static class (#917) test: add utils for multi instance tests (#914) test: downgrading testproject to 2020.3.12f1 (#927) refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913) chore: Change function signature of OnDespawnObject to accept NetworkObject (#928) fix: Empty prefab removal (#919)
SamuelBellomo
added a commit
that referenced
this pull request
Jul 6, 2021
…est/multiprocess-tests/execute-step-in-context * test/multiprocess-tests/base-multiprocess-tests: feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938) fix: reducing log level for noisy log and adding details for developer log (#926) feat: users can set authority on network transform programmatically (#868) refactor: move NetworkBehaviour update to a separate non-static class (#917) test: add utils for multi instance tests (#914) test: downgrading testproject to 2020.3.12f1 (#927) refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913) chore: Change function signature of OnDespawnObject to accept NetworkObject (#928) fix: Empty prefab removal (#919)
SamuelBellomo
added a commit
that referenced
this pull request
Jul 6, 2021
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: feat: log warning if detected child NetworkObjects under a NetworkPrefab (#938) fix: reducing log level for noisy log and adding details for developer log (#926) feat: users can set authority on network transform programmatically (#868) refactor: move NetworkBehaviour update to a separate non-static class (#917) test: add utils for multi instance tests (#914) test: downgrading testproject to 2020.3.12f1 (#927) refactor: decouple PendingSoftSyncObjects from NetworkSpawnManager (#913) chore: Change function signature of OnDespawnObject to accept NetworkObject (#928) fix: Empty prefab removal (#919) # Conflicts: # testproject/Packages/manifest.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a list was being removed from while iterated over.
networkPrefabIndexToRemovecontains indices of prefabs to remove in ascending order so we need to remove them in reverse order or else the indices all shift and we can an argument exception.