Release v0.26.0 (please TEST!) #10471
Comments
Merged
Merged
|
Does anyone else have a clearly noticeable stutter when swiping between channel tabs? Especially when swiping to Live, Playlists, and Channels. It's very consistent. And strangely, the stutter is worse once everything is loaded. If swiping to any of these tabs for the first time, the stutter is far less noticeable. I suspect the thumbnails. The pause happens just before they show up or go away. (It might be my old slow device or the debug channel causing this.) |
|
I can notice it too. But lowering thumbnail quality or completely disabling it doesn't reduce the amount of stutter. |
|
Accessing all types of videos, while thumbnail is disabled, causes a crash. Exception
Crash log
|
|
Just a small observation, I that if u turn on autorotate on device and use landscape mode |
|
Entering/exiting full screen consumes unexpectedly high amount of time. First app shownshown in the video is vanilla Newpipe version, the second one is debug version Screen_Recording_20231007_160533.mp4 |
|
Here my report about the OOMs during the feed refresh. It happens consistently for me, at around 150-250 subs processed. If the feed is open during the OOM-crash, it does not produce a guru-screen, putting the app in the backround and watching the notification for the crash, then bringing the app back, does produce a guru-screen. I've put some of them below. A heap dump taken during the refresh finds no obvious leaking objects in LeakCanary. I take this to mean that some component allocates memory incrementally per sub processed, that would be GCed if the refresh managed to finish. I can provide more info, if someone can instruct me on what's needed. ExceptionsException
Crash log
Exception
Crash log
Exception
Crash log
Exception
Crash log
|
5 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
|
From my testing, both the subscriptions- and the Whats-new-view do not contain shorts unless the "dedicated feed"/fast-mode is enabled. This matches pre-0.26.0 behaviour. |
|
@ChaosNicro There's a new setting: Fetch channel tabs. Have you opened it? |
|
Thanks for replying. All boxes are ticked and live-content does show up as intended, just shorts are missing. |
|
Mine is the opposite, Showing "shorts" all the time in subscriptions/whats new tabs. Even when unchecked as well as when Dedicated feed is enabled/disabled |
@ACR-Jeff Mind that unchecking the setting doesn't remove shorts from the database/feeds, it just prevents Newpipe from fetching new ones. I think that's by design. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
6 tasks
|
#10380 has also been fixed with this release. @opusforlife2, I can also feel heavy stutters while shifting through the channel tabs. Tested with both the debug apk and the nightly release as well. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
When a channel page is added as a tab to the home screen, the app crashes when I try to open a video from that tab. |
Exception
Crash log
|
|
Loading time is at least 3500 ms. slow.loading.mp4I can also feel a small but (relatively) noticeable delay in displaying the context menu when you want to enqueue videos. Is this intended? |
Don't bother testing delays in debug APKs. This is only worth checking on release APKs. |
The only way to know for sure is to compare the behaviour with the current release. When the exact same steps give different outcomes, that's a clue. |
If i import data only without the settings, then it works fine.... will do more tests and try to get a crash report. didn't get your last question but i do have 3 tabs of youtube channels if thats what you mean. |
In the current stable build (version 0.25.2), I can easily add and open 10+ channel pages without crash of any sort. Pretty safe to classify this as a regression. |
@Stypox You've linked my comment to this bullet point. This was me testing the first RC, and a debug build at that. With your RC2 release build, there is no lag. Someone else can test this to confirm, but I think this TODO can be removed. Edit: Okay there is still a minor hiccup with the older, slower device, though it is lesser than the debug build. |
|
@sigh8 @ChaosNicro could you test this APK and tell me if it fixes the out of memory crashes when loading feed? app-release.zip |
|
@Stypox I was able to get through 480 subs without fast-mode. Initial test passed. I'm gonna use this as my main NP for a bit to make sure. Would this also affect shorts not being processed without fast mode? |
|
@ChaosNicro Or you could stress test it for a shorter duration, and give a quicker feedback? |
Yeah, it solved the memory crash. Works for both normal mode(?) and fast mode. Thanks. Edit: This version is unable to get the like count. Was it supposed to happen? Exception
Crash log
|
The problem is gone. I got though 5 refreshs without any lag, where it would stall before. You can tick the box. |
|
@ChaosNicro could you check if the feed threshold works properly for you? I have set mine to 5 minutes but it still tries to refresh 41 subscriptions during cool down period. After cool down it still tries to refresh only 41 subscriptions. I have to restart the app for it to refresh all of the subscriptions. |
For me, 78 subs show up as "not loaded" (below the time since last refresh). Those ignore the threshold, as they should. A bit odd, since I remember that number being no more than two, but it's identical in pre-fix RC2 (ignoring the OOMs), so probably a Youtube thing instead of NP. @sigh8 are your 41 subs marked as "not loaded"? |
This was referenced Dec 20, 2023
|
Time for another RC, which includes the not-yet-merged PRs I opened in the last few hours. The following errors should be fixed, please confirm, and thanks for catching all of these errors before we release!
Release APK (built and signed by @Stypox): NewPipe_v0.26.0_RC3_release.zip
We are aware of that and will fix it. Yeah it's an extractor problem, YouTube changed the data returned about shorts yet again and removed the duration completely. |
Which one is the pre-fix RC2? If it's this one NewPipe_v0.26.0_RC2_release.zip, then for me it skips refreshing if threshold is not met. In v0.25 it refreshes two channels. shorts duration duplicate comment
Yes, they are. And are also ignored during the next refresh.
For me it now refreshes all of my channels after threshold is met if I have not tried to refresh during cool down period and 267 channels out 301 if I have. But every full(or almost full) refresh generates the bellow error. Clicking on "report" closes the app and takes me to the error page. But app continues to work fine if I ignore the error message and use it as is. Update : After I have enabled "fast mode", the error is not generated. Exception
Crash log
|
Not sure if I read this right, but this might be working as intended. AFAIK it tracks the threshold for each sub, so your "incomplete" refresh does not do all of them, because some of them had an attempt while the others were on "cool-down". If you wait at least 5 minutes since the last (incomplete) refresh, it should refresh all of them once more, since the thresholds are in sync again.
I suspect that this is the extractor failing to get durations. Since in fast-mode they are expected to be missing. (See Stypox's note above.)
Ignored, as in they ignore the threshold and are re-fetched on next refresh, or as in skipped until 5 minutes pass? It should be the first logically speaking and for me, it is. |
@Stypox I don't know about other users, but that's not the bug I reported. For me the lag is when I open a channel page and switch between channel tabs there. The older/less powerful the device, the more noticeable the lag. However, if it's something that can't be or isn't worth fixing for this release, that's also fine. It's a minor QoL issue. |
|
Hi, Exception
Exceptions (10)
Crash log 1
Crash log 2
Crash log 3
Crash log 4
Crash log 5
Crash log 6
Crash log 7
Crash log 8
Crash log 9
Crash log 10
|
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
@ddellarocca thanks for reporting, but that error is already known and we'll fix it before releasing, see my comment above |
1 task
|
Thank you everyone for helping with troubleshooting bugs and crashes! |
|
Has it been pulled from F-Droid? I can see 0.26.0 in F-Droid on a phone, but not on tablet. As well as F-Droid.org shows latest is 0.25.2. |
|
F-Droid's index hasn't been updated yet. You likely have the custom repo on your phone, but not your tablet. |
|
ahhh, right. There is archive.newpipe.net/fdroid/repo Added it so long ago. Forgot about it. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Testing for regressions
Release APK (built and signed by @Stypox): NewPipe_v0.26.0_RC3_release.zip
Debug APK (built by @Stypox): NewPipe_v0.26.0_RC3_debug.zip
Please report only regressions (i.e. new issues) here, not issues that were already present in previous releases!
TODO
Update some AndroidX libraries and compileSdk to 34 #10086Android 13+ custom notification actions #10580fullscreen takes time(it's a debug version artifact) Release v0.26.0 (please TEST!) #10471 (comment)App changelog
New
Access more content provided by creators which is grouped in different tabs (Add support for channel tabs and channel tags NewPipeExtractor#1082 and Add support for channel tabs #9182). The content of the channel tabs can vary by service:
Allow selecting image quality among multiple images Allow selecting image quality among multiple images #10062 Fix crash with disabled thumbnails when trying to play a stream #10482
NewPipe supports selecting the image quality among multiple image versions. This comes with three different presets which can be selected from within the settings (low, medium and high quality). This is most noticeable in the recently introduced card style for stream lists which is now able to show thumbnails in higher resolutions. Some services (e.g. YouTube) do not always provide the highest quality thumbnails for those lists.
Improved
ListInfoFragments depending onInfostream type Adjust empty state message for ListInfoFragments depending on Info stream type #10304Localization
Fixed
MediaFormatFix downloads of streams with missing MediaFormat #10165Development
MainActivity.tabSelected(MenuItem)SimplifyMainActivity.tabSelected(MenuItem)#10360Number.toFixed(0)withMath.floor()Image minizier: replace Number.toFixed(0) with Math.floor() #10377MathUtils.clampwith KotlincoerceInReplace MathUtils.clamp with Kotlin coerceIn #10224DeobfuscateExceptionhandling Update extractor and remove DeobfuscateException handling #10440NewPipe Extractor changelog
New
hasCreatorReply()toCommentsInfoItemAddhasCreatorReply()to CommentsInfoItem NewPipeExtractor#1111Improved
YoutubeJavaScriptExtractor[YouTube] Improve and fix YoutubeJavaScriptExtractor NewPipeExtractor#1087 [YouTube] Update stream mocks after #1087 NewPipeExtractor#1091Fixed
Development
StreamExtractorTest[Bandcamp] Fix StreamExtractorTest NewPipeExtractor#1105Locale.forLanguageTag()in tests Use Locale.forLanguageTag() in tests NewPipeExtractor#1107The text was updated successfully, but these errors were encountered: