Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved accessibility of player interfaces #10199

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Jul 1, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Add content descriptions for most player actions.

ToDo

  • Test the changes and wait for feedback No feedback from original reporters

Fixes the following issue(s)

APK testing

Download the APK via this URL: https://github.com/TeamNewPipe/NewPipe/suites/13997135622/artifacts/780985251
This downloads a zip file (app.zip) which contains the debug APK of this PR.

Due diligence

@TobiGr TobiGr added player Issues related to any player (main, popup and background) accessibility Issue is related to accessibility labels Jul 1, 2023
@TobiGr TobiGr force-pushed the feat/player/accessibility branch from 3bea98e to fdfc4df Compare July 1, 2023 22:19
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@TobiGr TobiGr requested a review from Stypox September 18, 2023 01:12
@TeamNewPipe TeamNewPipe deleted a comment from sonarcloud bot Sep 20, 2023
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TobiGr
Copy link
Member Author

TobiGr commented Sep 21, 2023

rebased

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TobiGr TobiGr merged commit e2de831 into dev Sep 21, 2023
8 checks passed
@TobiGr TobiGr deleted the feat/player/accessibility branch September 21, 2023 13:58
This was referenced Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue is related to accessibility player Issues related to any player (main, popup and background)
Projects
None yet
3 participants