Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified] Accessibility: most buttons have no title / content description #4303

Closed
TobiGr opened this issue Sep 21, 2020 · 5 comments · Fixed by #10199
Closed

[Unified] Accessibility: most buttons have no title / content description #4303

TobiGr opened this issue Sep 21, 2020 · 5 comments · Fixed by #10199
Assignees
Labels
accessibility Issue is related to accessibility bug Issue is related to a bug GUI Issue is related to the graphical user interface

Comments

@TobiGr
Copy link
Member

TobiGr commented Sep 21, 2020

Version

Steps to reproduce the bug

  1. Enable "text to speech" in accessibility settings
  2. open a video in NewPipe
  3. Play a video
  4. tap on any button in the video ->

Expected behavior

You'll get a description of the button's action.

Actual behaviour

Device says "unlabelled button"

@TobiGr TobiGr added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Sep 21, 2020
@B0pol B0pol added the accessibility Issue is related to accessibility label Sep 27, 2020
@TobiGr TobiGr self-assigned this Dec 25, 2021
@TobiGr TobiGr changed the title [Unified] Accessibility: most buttons have no title [Unified] Accessibility: most buttons have no title / content description Dec 25, 2021
@TobiGr
Copy link
Member Author

TobiGr commented Dec 25, 2021

I am currently working on this. Should we use "track" or "stream" for content descriptions?
E.g. i could have a description for the duration of the currently playing stream. Should this be "track duration" or "stream duration"? CC @bmivzkrp

@bmivzkrp
Copy link

@TobiGr In my opinion - easier:

"Duration"

That is, we provide only the necessary amount of information. The blind user will understand from the context.

@bmivzkrp
Copy link

Regarding "overlay play pause button": if possible, it would be great if the behavior was as follows:

  1. During playback, this button is called "Pause".
  2. During the pause, the button is called "Play".
    The same goes for the player.
    In general, in such cases, it would be ideal if the controls change the name, depending on the state.

@ShareASmile
Copy link
Collaborator

ShareASmile commented Jun 16, 2023

is this being worked upon ?
I think @TobiGr forgot about it😅

@TobiGr
Copy link
Member Author

TobiGr commented Jul 1, 2023

Please test the APK provided in #10199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue is related to accessibility bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants