Improve the download helpers using the Java 7 NIO API. #10248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
NIO_downloads
branch
from
4880837
to
9e08267
Compare
Isira-Seneviratne
force-pushed
the
NIO_downloads
branch
from
9e08267
to
1a1fa7c
Compare
Isira-Seneviratne
force-pushed
the
NIO_downloads
branch
from
1a1fa7c
to
cfd0a21
Compare
TobiGr
force-pushed
the
NIO_downloads
branch
from
cfd0a21
to
0c2507d
Compare
Remove unnecessary else-branch and use Collections.isEmpty(). Add doc comment for splitFilename()
The RuntimeException was not explicitly declared and thus not caught at every call of this constructor. This change ensures that this possible exception is handled by the dedicated error handlers.
TobiGr
force-pushed
the
NIO_downloads
branch
from
0c2507d
to
f2c2f17
Compare
TobiGr
approved these changes
Sep 17, 2023
TobiGr
added
downloader
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Oct 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
desugar_jdk_libs_nioconfiguration (more information on it can be found here).FileAPI, including lazy file loading on Android 8.0 and later, and more informative exceptions if something goes wrong. It should be possible to replace theSharpStreaminterface withSeekableByteChannelin a future PR with this change.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence