Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the download helpers using the Java 7 NIO API. #10248

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Improve the download helpers using the Java 7 NIO API. #10248

merged 4 commits into from
Sep 17, 2023

Commits on Sep 17, 2023

  1. Use desugar_jdk_libs_nio.

    @Isira-Seneviratne @TobiGr
    Isira-Seneviratne authored and TobiGr committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    2cb973f View commit details
    Browse the repository at this point in the history

  2. Use Path in the download helper classes.

    @Isira-Seneviratne @TobiGr
    Isira-Seneviratne authored and TobiGr committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    6df808f View commit details
    Browse the repository at this point in the history

  3. Small code and doc improvements 

    Remove unnecessary else-branch and use Collections.isEmpty().
Add doc comment for splitFilename()
    @TobiGr
    TobiGr committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    4e41e12 View commit details
    Browse the repository at this point in the history

  4. Replace RuntimeException with IOException 

    The RuntimeException was not explicitly declared and thus not caught at every call of this constructor. This change ensures that this possible exception is handled by the dedicated error handlers.
    @TobiGr
    TobiGr committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    f2c2f17 View commit details
    Browse the repository at this point in the history