Fix crashes due to wrong root fragment manager #10645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
In NewPipe the
MainFragment
is entitled to handling the fragment backstack and the collapsible player fragment. Therefore any action involving opening new fragments (e.g. when clicking on videos/playlists/...) needs to be performed on theMainFragment
's fragment manager. The previous implementation chose the fragment manager assuming that every fragment is at most singly nested (i.e. where the parent is directlyMainFragment
). However the new main page channel tab contains doubly-nested fragments (i.e. the channel tabs), so the previous method was choosing the wrong fragment manager, making the app crash. This PR fixes the issue by properly finding the root fragment.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence