Add support for channel tabs #9182

Theta-Dev · 2022-10-23T23:08:32Z

What is it?

Feature (user facing)

Description of the changes in your PR

Because YouTube is planning to update their channel page layout (as announced here) and divide videos into 3 tabs (regular videos, shorts, livestreams), we need to add this layout to the NewPipe app to be able to access all channel content.

This PR adds a tabbed channel layout with tabs for videos, shorts, livestreams, playlists, featured channels and channel info and a setting to hide certain channel tabs.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Old versions

app-debug.zip
app-debug2.zip (update: merged the latest extractor commits, fixes like count extraction)
app-debug3.zip (update: cache channel data, fix NPE crash, add Bandcamp album support)
app-debug4.zip (update: small extractor bugfix, extract upload date from shorts (edit: this info not returned anymore for shorts on the corresponding channel tab), show albums from YouTube Music artist channels)
app-debug5.zip (update: show channel header regardless of channel tab, collapsed when scrolling down)
app-debug6.zip (update: correct channel header theme)
APK signed by Stypox: app-debug.zip.

Due diligence

I read the contribution guidelines.

opusforlife2 · 2022-10-24T02:00:56Z

Dun dun DUUUUUUUN. It's happening. It's finally happening. ಥ‿ಥ

opusforlife2 · 2022-10-24T11:21:52Z

Opening non-video items in channel tabs and then going back causes the entire channel info to be loaded again. Can it not be cached? Or opened as a fragment or something like video details pages are?

Crash crash crash! If you open any item from a non-video channel tab and then open a video, going full screen causes this crash:

FATAL EXCEPTION: main
Process: org.schabi.newpipe.debug.channeltabs, PID: 17217
java.lang.NullPointerException: Attempt to read from field 'com.google.android.material.tabs.TabLayout org.schabi.newpipe.databinding.FragmentChannelBinding.tabLayout' on a null object reference
	at org.schabi.newpipe.fragments.list.channel.ChannelFragment.onSaveInstanceState(ChannelFragment.java:134)
	at androidx.fragment.app.Fragment.performSaveInstanceState(Fragment.java:3183)
	at androidx.fragment.app.FragmentStateManager.saveBasicState(FragmentStateManager.java:680)
	at androidx.fragment.app.FragmentStateManager.saveState(FragmentStateManager.java:646)
	at androidx.fragment.app.FragmentStore.saveActiveFragments(FragmentStore.java:214)
	at androidx.fragment.app.FragmentManager.saveAllStateInternal(FragmentManager.java:2318)
	at androidx.fragment.app.FragmentManager.lambda$attachController$0$androidx-fragment-app-FragmentManager(FragmentManager.java:2572)
	at androidx.fragment.app.FragmentManager$$ExternalSyntheticLambda0.saveState(Unknown Source:2)
	at androidx.savedstate.SavedStateRegistry.performSave(SavedStateRegistry.kt:247)
	at androidx.savedstate.SavedStateRegistryController.performSave(SavedStateRegistryController.kt:81)
	at androidx.activity.ComponentActivity.onSaveInstanceState(ComponentActivity.java:338)
	at android.app.Activity.performSaveInstanceState(Activity.java:2203)
	at android.app.Instrumentation.callActivityOnSaveInstanceState(Instrumentation.java:1520)
	at android.app.ActivityThread.callActivityOnSaveInstanceState(ActivityThread.java:5830)
	at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:5229)
	at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:5784)
	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:5703)
	at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:71)
	at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2253)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7870)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Theta-Dev · 2022-10-25T08:47:28Z

@opusforlife2 I published a new debug build (v3) that should fix your issues

opusforlife2 · 2022-10-25T12:33:43Z

Confirmed. Thanks!

tvnmguy · 2022-10-29T05:56:34Z

Some design suggestion for new channel tabs!

Some channels doesn't feature Home video, then the Home tab look like this👇

tvnmguy · 2022-10-29T08:02:35Z

Is possible to implement search something in a channel? If possible... My design is here👇

Theta-Dev · 2022-10-29T08:21:41Z

@SameenAhnaf Did you open this playlist from the channel playlists tab? I tried it and could not reproduce this issue.

This PR does not touch any playlist extraction code, so that issue may also occur when opening a playlist manually.

A quick fix would be to clear the cache and reopen the playlist.

SameenAhnaf · 2022-10-29T18:33:13Z

@Theta-Dev AudricV successfully solved the bug in extractor. Anyway, #5746 & #9223 could be linked with this PR.

Btw, do you have any plan how to integrate 3 separate tabs' loading into one what's new feed? Or, split what's new feed into three tabs on another PR? I noticed that recent shorts and live videos are not included in what's new feed.

Theta-Dev · 2022-10-29T20:04:27Z

It is not possible to merge all 3 tabs into one feed because YouTube does not show the upload date of shorts.

We could omit the shorts and merge the video and livestream tab into the feed.

An alternative would be to fetch both the video tab and the RSS feed. That would be faster than fetching 2 tabs and we would still get all the shorts and livestreams

SameenAhnaf · 2022-10-29T20:23:09Z

Is it within scope of this PR to split what's new feed into three tabs? An issue is inevitable in this regard.

An alternative would be to fetch both the video tab and the RSS feed.

I think, this point should be discussed in #4934 instead. Many users have limited access to cellular data and this should be an option, not the only way.

opusforlife2 · 2022-10-30T16:32:10Z

I haven't set the visitor data cookie, yet I'm suddenly seeing the Shorts and Live tabs. I wasn't seeing them a couple of days ago when I tested debug3. A/B testing is the culprit, I assume?

killerrook · 2022-10-31T20:03:35Z

App debug 3 is working all right even without entering any cookie no problem during video playback using it instead of official new pipe release for 3 days

killerrook · 2022-11-01T13:53:36Z

If the app remains open and android goes in deep sleep or app is killed by android. The following error shows up 4-5 times. Then keep pressing back and app will be closed after all error reports are shown. Upon reopening it will work fine again. Consistent issue.Hope that helps.

Exception

User Action: ui error
Request: ACRA report
Content Country: US
Content Language: en-US
App Language: en_US
Service: none
Version: 0.24.0
OS: Linux OPPO/CPH1861/CPH1861:9/PPR1.180610.011/1587903909:user/release-keys 9 - 28

Crash log

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.schabi.newpipe.debug.channeltabs/org.schabi.newpipe.MainActivity}: android.os.BadParcelableException: ClassNotFoundException when unmarshalling: androidx.fragment.app.FragmentManagerState
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3175)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3312)
	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:113)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:71)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2038)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:226)
	at android.app.ActivityThread.main(ActivityThread.java:7178)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:503)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:942)
Caused by: android.os.BadParcelableException: ClassNotFoundException when unmarshalling: androidx.fragment.app.FragmentManagerState
	at android.os.Parcel.readParcelableCreator(Parcel.java:2855)
	at android.os.Parcel.readParcelable(Parcel.java:2781)
	at android.os.Parcel.readValue(Parcel.java:2684)
	at android.os.Parcel.readArrayMapInternal(Parcel.java:3053)
	at android.os.BaseBundle.initializeFromParcelLocked(BaseBundle.java:288)
	at android.os.BaseBundle.unparcel(BaseBundle.java:232)
	at android.os.Bundle.getParcelable(Bundle.java:940)
	at androidx.fragment.app.FragmentManager.attachController(FragmentManager.java:2583)
	at androidx.fragment.app.FragmentController.attachHost(FragmentController.java:116)
	at androidx.fragment.app.FragmentActivity.lambda$init$1$androidx-fragment-app-FragmentActivity(FragmentActivity.java:128)
	at androidx.fragment.app.FragmentActivity$$ExternalSyntheticLambda1.onContextAvailable(Unknown Source:2)
	at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99)
	at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:322)
	at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:249)
	at org.schabi.newpipe.MainActivity.onCreate(MainActivity.java:136)
	at android.app.Activity.performCreate(Activity.java:7383)
	at android.app.Activity.performCreate(Activity.java:7374)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3155)
	... 11 more

SameenAhnaf · 2022-11-05T17:06:32Z

Channel tabs seem to be inaccessible if added as a content on main page. Only, normal videos are shown.

Theta-Dev · 2022-11-06T00:58:56Z

Channel tabs seem to be inaccessible if added as a content on main page. Only, normal videos are shown.

That is intentional. The main page already used a tabbed layout, so we cant have another tab bar inside.

tsiflimagas · 2022-11-06T01:17:01Z

One thing I noticed is that when being on any tab other than the "VIDEOS" one, if you rotate the screen, you're moved back to it (the videos tab).

Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space

YouTube's "Desktop Max" thumbnails are 2560x423, while our previous placeholder banner was 2550x427. The extractor actually returns a lower resolution "Desktop Max" banner at 1060x175, but the ratio wrt 2560x423 is off by ~0.1% The PNG was optimized with OptiPNG

Since it is embedded in the app bar and has red as background color, it should be themed in the same way as the toolbar.

Increase readability

This empty element should be always hidden for this tab, as there is no upload date available for channels.

The breakage of these tests is related to the channel tabs changes. The testRememberRecentStreams test method has been removed, as it doesn't seem to be relevant anymore to managing subscriptions.

Add the separate utility class PlayButtonHelper to handle the initialization of the listeners. The ClickListeners on playlist controls had different behaviours. This commit fixes that. The commit also refactors the way how the app determines whether it is started for the first time. The previous version was not clean and recent in this PR caused it to fail.

Co-Authored-By: Audric V <74829229+AudricV@users.noreply.github.com>

…ng ChannelFragment

TobiGr

We were not able to reproduce @Feuerswut's crash and assume that it was caused by an unsupported backup version. The goal is to merge this PR and get the changes into the nightlies to reach a broader testing audience.

AudricV · 2023-09-18T21:28:05Z

Shorts do not seem to be fetched in my feed, did we decide to just ignore those? We should probably show a warning if that's the case, and remove the entry from the "Fetch channel tabs" setting

No, that's because the extractor version is old and has the bug described in TeamNewPipe/NewPipeExtractor#1077.

Maybe we might want to merge the "Channels" tab with the "About" tab. Related channels are not really a content of the channel, but rather a metadata item, and as such they are used less frequently and in my opinion would fit better in its section in the "About" tab. This would also reduce the amount of tabs by 1, making scrolling simpler.

I tend to disagree, as theoretically, a channel could have hundreds of related channels, which would fit better in a separate tab in this case.

The shorts playlist workaround doesn't allow us to fetch shorts upload dates anymore, right? YouTube removed dates there too. Do we want to try with the Smart TV client as suggested here?

No, see TeamNewPipe/NewPipeExtractor#1077 for a discussion and reasons around that.

sonarcloud · 2023-09-18T21:34:49Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

0.0% Coverage
0.0% Duplication

opusforlife2 · 2023-09-18T21:57:04Z

We should mark this historic day by making it an international holiday, I say.

TobiGr added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface multiservice Issues related to multiple services deep review required Maintainer must double check/test/review this due to changes in API or architecture labels Oct 24, 2022

Stypox mentioned this pull request Oct 25, 2022

[HELP NEEDED] Major planned/missing features #6448

Open

34 tasks

This comment was marked as off-topic.

Sign in to view

heberjeur mentioned this pull request Nov 5, 2022

View channel details #9302

Closed

6 tasks

killerrook mentioned this pull request Nov 5, 2022

Unable to see videos of a channel when visiting channel info #9301

Closed

6 tasks

This comment was marked as spam.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Theta-Dev and others added 22 commits September 18, 2023 23:22

update NPE

a2a717b

feat: filter fetched channel tabs

28d952a

add channel banner placeholder

dca32ef

Add space above channel description (About tab)

013d513

Add avatar and bannner URLs to channel About tab

1061bce

Improve placeholder channel banner handling

c48e702

Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space

Show snackbar with feed loading errors

6b3a178

Fix loading feed when a channel tab is empty

1519527

Use consistent name for livestreams tab in settings keys

6f23b56

Fix wrongly themed channel header

9e55014

Since it is embedded in the app bar and has red as background color, it should be themed in the same way as the toolbar.

Update NewPipeExtractor and adapt imports

78b4b94

Add missing @Override annotations to setupMetadata() implementations

5c7c382

Extract actual feed loading code into separate method

6ab8716

Increase readability

Always show the About tab and support having no description

89dc44b

Hide the upload date element on the About tab

f2ee385

This empty element should be always hidden for this tab, as there is no upload date available for channels.

Remove unneeded German translation

8fbc8ff

Fix SubscriptionManagerTest tests

0d9910c

The breakage of these tests is related to the channel tabs changes. The testRememberRecentStreams test method has been removed, as it doesn't seem to be relevant anymore to managing subscriptions.

Apply review

57eaa1b

Co-Authored-By: Audric V <74829229+AudricV@users.noreply.github.com>

Fix previous ActionBar title visible for a few miliseconds when openi…

64da7a0

…ng ChannelFragment

Remove unused content not supported TextView

031b893

TobiGr approved these changes Sep 18, 2023

View reviewed changes

Stypox force-pushed the channel-tabs branch from e7abcd4 to 031b893 Compare September 18, 2023 21:23

Stypox merged commit 0eae9e7 into TeamNewPipe:dev Sep 18, 2023
4 of 6 checks passed

SameenAhnaf mentioned this pull request Sep 19, 2023

[YouTube] Channel page - Shorts videos no longer display their duration #8034

Closed

5 tasks

AudricV mentioned this pull request Oct 16, 2023

Release v0.26.0 (please TEST!) #10471

Closed

21 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for channel tabs #9182

Add support for channel tabs #9182

Theta-Dev commented Oct 23, 2022 •

edited by TobiGr

Loading

opusforlife2 commented Oct 24, 2022

opusforlife2 commented Oct 24, 2022

Theta-Dev commented Oct 25, 2022

opusforlife2 commented Oct 25, 2022

This comment was marked as off-topic.

tvnmguy commented Oct 29, 2022 •

edited by Stypox

Loading

tvnmguy commented Oct 29, 2022 •

edited by Stypox

Loading

Theta-Dev commented Oct 29, 2022

SameenAhnaf commented Oct 29, 2022 •

edited

Loading

Theta-Dev commented Oct 29, 2022 •

edited

Loading

SameenAhnaf commented Oct 29, 2022 •

edited

Loading

opusforlife2 commented Oct 30, 2022

killerrook commented Oct 31, 2022

killerrook commented Nov 1, 2022 •

edited

Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

SameenAhnaf commented Nov 5, 2022

Theta-Dev commented Nov 6, 2022

tsiflimagas commented Nov 6, 2022

This comment was marked as spam.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

TobiGr left a comment

AudricV commented Sep 18, 2023

sonarcloud bot commented Sep 18, 2023

opusforlife2 commented Sep 18, 2023

Add support for channel tabs #9182

Add support for channel tabs #9182

Conversation

Theta-Dev commented Oct 23, 2022 • edited by TobiGr Loading

What is it?

Description of the changes in your PR

Before/After Screenshots/Screen Record

Fixes the following issue(s)

Relies on the following changes

APK testing

Due diligence

opusforlife2 commented Oct 24, 2022

opusforlife2 commented Oct 24, 2022

Theta-Dev commented Oct 25, 2022

opusforlife2 commented Oct 25, 2022

This comment was marked as off-topic.

tvnmguy commented Oct 29, 2022 • edited by Stypox Loading

tvnmguy commented Oct 29, 2022 • edited by Stypox Loading

Theta-Dev commented Oct 29, 2022

SameenAhnaf commented Oct 29, 2022 • edited Loading

Theta-Dev commented Oct 29, 2022 • edited Loading

SameenAhnaf commented Oct 29, 2022 • edited Loading

opusforlife2 commented Oct 30, 2022

killerrook commented Oct 31, 2022

killerrook commented Nov 1, 2022 • edited Loading

Exception

This comment was marked as off-topic.

This comment was marked as off-topic.

SameenAhnaf commented Nov 5, 2022

Theta-Dev commented Nov 6, 2022

tsiflimagas commented Nov 6, 2022

This comment was marked as spam.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

TobiGr left a comment

Choose a reason for hiding this comment

AudricV commented Sep 18, 2023

sonarcloud bot commented Sep 18, 2023

opusforlife2 commented Sep 18, 2023

Theta-Dev commented Oct 23, 2022 •

edited by TobiGr

Loading

tvnmguy commented Oct 29, 2022 •

edited by Stypox

Loading

tvnmguy commented Oct 29, 2022 •

edited by Stypox

Loading

SameenAhnaf commented Oct 29, 2022 •

edited

Loading

Theta-Dev commented Oct 29, 2022 •

edited

Loading

SameenAhnaf commented Oct 29, 2022 •

edited

Loading

killerrook commented Nov 1, 2022 •

edited

Loading