Replace MathUtils.clamp with Kotlin coerceIn

[TacoTheDank]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Replace 'MathUtils.clamp' with Kotlin 'coerceIn' where possible
• Also utilize the isGone extension function

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[AudricV]

Are you sure about your changes? A part of them has been intentionally reverted with #8737.

[TacoTheDank]

@AudricV That's interesting, I wasn't aware of that.

If the problem is that (playerUi.screenWidth - playerUi.popupLayoutParams.width).toFloat() or (playerUi.screenHeight - playerUi.popupLayoutParams.height).toFloat() can somehow result in a negative number and therefore crash because it is less than the minimum (0f), then I think we can just use Kotlin's coerceAtLeast to make sure numbers can't go below '0f'. coerceAtLeast looks like this:

public fun Float.coerceAtLeast(minimumValue: Float): Float {
    return if (this < minimumValue) minimumValue else this
}

This would ensure we always have a maximum of at least '0f' and avoid a crash.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

ktlint fails

Outdated review

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[TobiGr]

LGTM