Restore player service start handling before player UI separation and fix some issues in this service #10578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
bug
This behavior was present before 0.24.0 and the player UI separation and avoided crashes for which their exception contained "Context.startForegroundService() did not then call Service.startForeground()". Some player nullability checks have been also added, and the player service is now stopped when it has been started from a media button and there is nothing to play.
AudricV
force-pushed
the
try-fix-player-service-foreground-start
branch
from
69e1e7d
to
84d50da
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
Nov 16, 2023
|
I'm so looking forward to not being nagged by my friends about this. Is there any scope of this being backported to the current RC for a quicker turnaround? It's a pretty widespread set of bugs, after all. |
|
Yes this is going in the current RC as soon as I get to it |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR restores the player service start handling before player UI separation, shipped with 0.24.0. This handling avoided crashes about the service service not starting in the foreground, in time or not at all (so crashes for which their exception contained
Context.startForegroundService() did not then call Service.startForeground()). See #9358 (comment) for more details.This PR also adds some player nullability checks, and the player service is now stopped when it has been started from a media button and there is nothing to play, which should avoid empty player notifications with the previous behavior.
A proper and better player code and architecture is required in order to solve this player service issue in the good way, which must be made in the upcoming app rewrite.
Fixes the following issue(s)
Although this PR should fixes these issues, there is a chance, thanks to the current bad player code, that it may not fix them entirely; if so, it should mitigate them a lot.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence