Consistent crash if video player closed before the video loads

[Jaydepps]

Checklist

• I am able to reproduce the bug with the latest version.
• I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• I have read the FAQ and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected version

0.24.1

Steps to reproduce the bug

1. Start playing video
2. Before video loads back out and close the small player by either taping the x or swiping down

Expected behavior

Video playback stops

Actual behavior

Newpipe crashes

Screenshots/Screen recordings

XRecorder_Edited_23112022_022904.mp4

Logs

Exception

• User Action: ui error
• Request: ACRA report
• Content Country: GB
• Content Language: en-GB
• App Language: en_GB
• Service: none
• Version: 0.24.1
• OS: Linux HUAWEI/MAR-LX1AEEA/HWMAR:10/HUAWEIMAR-L21A/10.0.0.233C431:user/release-keys 10 - 29

Crash log

android.app.RemoteServiceException: Context.startForegroundService() did not then call Service.startForeground(): ServiceRecord{e233f40 u0 org.schabi.newpipe/.player.PlayerService}
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2540)
	at android.os.Handler.dispatchMessage(Handler.java:110)
	at android.os.Looper.loop(Looper.java:219)
	at android.app.ActivityThread.main(ActivityThread.java:8668)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1109)

---

Affected Android/Custom ROM version

Android 10 / EMUI 12.0.0

Affected device model

Huawei P30 Lite

Additional information

No response

[opusforlife2]

What's the value of Smallest width in Developer options?

[Jaydepps]

423 dp (system default)

[opusforlife2]

Your video is blank. Try uploading again?

[Jaydepps]

https://user-images.githubusercontent.com/61331785/204088226-97b79eda-0743-4bb7-b67d-d2071cff8098.mp4
Video uploaded again

[opusforlife2]

Ah, it's the same problem. You'll have to make a new video. Is this playing for you in the browser?

Edit: actually, never mind. I'm pretty sure I know what the bug is, but just to confirm, you try to close the player while the initial buffering is ongoing? Black screen with loading indicator; seekbar is a dark red and no start and end time is shown?

[Jaydepps]

The video is playing fine for me, I checked on multiple devices.

Yes, the crash occurs when you attempt to close the player while its initially loading.

[Jaydepps]

HwVideoEditor_2022_11_26_161133740.mp4

New video

[opusforlife2]

It's the same issue I reported here: #8646 (comment)

But I only get it on Tablet mode (Smallest width >480 dp). You seem to be getting it even on Phone layout.

Just to cover all bases, is Tablet mode off in Appearance?

[Jaydepps]

Tablet mode is off, yes.

[Douile]

Reproducible on android 11 (lineage 18.1), smallest width 587dp (smallest display and font size in android/display settings), for both tablet mode on and off. Although it doesn't just happen when closing video before load for me: same crash log when notification group is closed while loading, or sometimes while refreshing feed with video playing, or closing playing video while feed is refreshing. Not sure if these are more related to other issue posted but its the same crash log so posted here.

[opusforlife2]

@Douile Change your smallest width to less than 480 dp and see if it still occurs.

[Douile]

Yes it still occurs