Crash on closing a video

[n-1x]

Checklist

• I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
• I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• I have read the FAQ and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected version

0.25.2

Steps to reproduce the bug

1. Play any video
2. Drag down to minimise it
3. Hit the x to close, then immediately drag up the video again before it's fully closed.
4. Attempt to play the video, it won't work, this is already a bugged state.
5. Drag down again and close it, causing the crash 100% of the time.

Expected behavior

Should not be able to drag up after tapping the x to close the video.

Actual behavior

Can access a bugged video view where the video cannot be played and the UI can crash.

Screenshots/Screen recordings

No response

Logs

Exception

• User Action: ui error
• Request: ACRA report
• Content Country: GB
• Content Language: en-GB
• App Language: en_GB
• Service: none
• Version: 0.25.2
• OS: Linux Android 13 - 33

Crash log

android.app.RemoteServiceException$ForegroundServiceDidNotStartInTimeException: Context.startForegroundService() did not then call Service.startForeground(): ServiceRecord{1ac8192 u0 org.schabi.newpipe/.player.PlayerService}
	at android.app.ActivityThread.generateForegroundServiceDidNotStartInTimeException(ActivityThread.java:2245)
	at android.app.ActivityThread.throwRemoteServiceException(ActivityThread.java:2216)
	at android.app.ActivityThread.-$$Nest$mthrowRemoteServiceException(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2508)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:226)
	at android.os.Looper.loop(Looper.java:313)
	at android.app.ActivityThread.main(ActivityThread.java:8757)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
Caused by: android.app.StackTrace: Last startServiceCommon() call for this service was made here
	at android.app.ContextImpl.startServiceCommon(ContextImpl.java:1988)
	at android.app.ContextImpl.startForegroundService(ContextImpl.java:1933)
	at android.content.ContextWrapper.startForegroundService(ContextWrapper.java:839)
	at androidx.core.content.ContextCompat$Api26Impl$$ExternalSyntheticApiModelOutline1.m(R8$$SyntheticClass:0)
	at androidx.core.content.ContextCompat$Api26Impl.startForegroundService(ContextCompat.java:1091)
	at androidx.core.content.ContextCompat.startForegroundService(ContextCompat.java:749)
	at org.schabi.newpipe.player.helper.PlayerHolder.startService(PlayerHolder.java:133)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.openMainPlayer(VideoDetailFragment.java:1116)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.$r8$lambda$2AqzXzm7Dd_AK59LBgrtlNnr-I8(VideoDetailFragment.java:0)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment$$ExternalSyntheticLambda47.run(R8$$SyntheticClass:0)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.replaceQueueIfUserConfirms(VideoDetailFragment.java:2081)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.openVideoPlayer(VideoDetailFragment.java:1083)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.openVideoPlayerAutoFullscreen(VideoDetailFragment.java:1096)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.lambda$setOnClickListeners$4(VideoDetailFragment.java:468)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.$r8$lambda$HFryZg4muEkRM7BhMC5d1oTjLtg(VideoDetailFragment.java:0)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment$$ExternalSyntheticLambda22.onClick(R8$$SyntheticClass:0)
	at android.view.View.performClick(View.java:7892)
	at android.view.View.performClickInternal(View.java:7869)
	at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
	at android.view.View$PerformClick.run(View.java:30880)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	... 6 more

---

Affected Android/Custom ROM version

Android 13

Affected device model

Galaxy S21 Ultra

Additional information

No response

[CaitlinDahl]

Hi, I am interested in working on this issue as part of a uni assignment. May I have the issue assigned to me?

[opusforlife2]

The app is currently on a feature freeze. Please wait for the team's go ahead before starting any work.

[u7498708]

I know you are under a feature freeze but is there anything I can do for this issue or something of similiar nature? @opusforlife2

[opusforlife2]

Like I said, the team will state it if something can be done.