Skip to content

Conversation

@brianparry
Copy link
Contributor

Merge latest master into feature/ibms branch

mtannous and others added 30 commits October 26, 2016 18:17
Add errors type to swagger ErrorResponse schema
create ssh keys at startup for Esxi
Add ssh public key for Inband management.
return empty object when access api without token or with error token
-To make the static Ip work
-Added a post notication callback
after the static IP is set as part of max payload
Update the suse ks-script:
When we ask bootstrap.js to exit we pass the value as the `exit` member of the tasks structure. Problem is that bootstrap.js seems to expect it to be `exit.code`. I've fixed this defensively as I'm not sure if there are prior installations that expect the `exit.code` value.
…t-enhancement

Windows os regression script enhancement
…ions-enhancement

adding more options support in CoreOS yaml
Fix exit code handling in bootstrap.js
tgelter and others added 24 commits January 9, 2017 15:23
 * This PR is to address Felix's comments on ipxe progress
   API,_getActiveTask function and progress data type.
 * Code is udpated based on comments.
 * No feature impacted.
RAC-3801 ESXi 6.0 OS installation failure when network interface is s…
add vscode config into gitignore list
Inject GRUB customizations to support CoreOS Ignition
to skip the generation of pollers on a compute node
…-for-release

[skip ci]modify debian info for release
fix houndci parse error by removing comment in jshintrc
Add skipPollerOption to determine creating or skipping
Change title names for doc generation
Stop TravisCI to upload deb to Bintray on-http
Conflicts:
	lib/serializables/v1/ssh.js
	spec/lib/serializables/v1/ssh-spec.js
	static/monorail-2.0.yaml
nodeApiService
) {

var logger = Logger.initialize(templateApiServiceFactory);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'logger' is defined but never used.

@JenkinsRHD
Copy link
Contributor

BUILD on-http #3097 : FAILURE

BUILD unit-tests #11033 Error Logs ▼Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a list of the node's ssh settings Error Details: Cannot read property 'findAllByNode' of undefined Stack Trace: TypeError: Cannot read property 'findAllByNode' of undefined at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:383:27)

Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a 404 if the node has no ssh settings
Error Details: Cannot read property 'findAllByNode' of undefined
Stack Trace: TypeError: Cannot read property 'findAllByNode' of undefined
at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:400:27)

Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should replace existing settings with a new set of ssh settings
Error Details: Cannot read property 'upsertByNode' of undefined
Stack Trace: TypeError: Cannot read property 'upsertByNode' of undefined
at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:436:27)

Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should add a new set of ssh settings if none exist
Error Details: Cannot read property 'upsertByNode' of undefined
Stack Trace: TypeError: Cannot read property 'upsertByNode' of undefined
at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:449:27)

Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should return a 404 if the node was not found
Error Details: expected 404 "Not Found", got 400 "Bad Request" Response body: { message: '&#34;ssh-ibm-service.json#/definitions/Ibm is not loaded&#34;', status: '400', UUID: '51106c3e-5334-4bb8-927f-e410377de970' } Error: expected 404 "Not Found", got 400 "Bad Request" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17)
Stack Trace: Error: expected 404 "Not Found", got 400 "Bad Request"
at Test._assertStatus (node_modules/supertest/lib/test.js:232:12)
at Test._assertFunction (node_modules/supertest/lib/test.js:247:11)
at Test.assert (node_modules/supertest/lib/test.js:148:18)
at assert (node_modules/supertest/lib/test.js:127:12)
at node_modules/supertest/lib/test.js:124:5
at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3)
at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12)
at endReadableNT (_stream_readable.js:921:12)

Test Name: Http.Api.Ibms /api/2.0/ibms/definitions should get the ssh IBM schema
Error Details: expected 200 "OK", got 404 "Not Found" Response body: { message: '/api/2.0/ibms/definitions/ssh-ibm-service.json Not Found', status: '404', UUID: '44934798-755a-4f12-bdf0-36abea3f692e' } Error: expected 200 "OK", got 404 "Not Found" at Test._assertStatus (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:921:12) at nextTickCallbackWith2Args (node.js:442:9) at process._tickDomainCallback (node.js:397:17)
Stack Trace: Error: expected 200 "OK", got 404 "Not Found"
at Test._assertStatus (node_modules/supertest/lib/test.js:232:12)
at Test._assertFunction (node_modules/supertest/lib/test.js:247:11)
at Test.assert (node_modules/supertest/lib/test.js:148:18)
at assert (node_modules/supertest/lib/test.js:127:12)
at node_modules/supertest/lib/test.js:124:5
at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3)
at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12)
at endReadableNT (_stream_readable.js:921:12)

Test Name: Http.Api.Ibms /api/2.0/ibms should return a list of IBM instances
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:106:26)

Test Name: Http.Api.Ibms /api/2.0/ibms should put an IBM instance
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:121:26)

Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with unloaded schema
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:133:26)

Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with missing field
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:145:26)

Test Name: Http.Api.Ibms /api/2.0/ibms/:id "before each" hook for "should get an IBM instance"
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:160:19)

Test Name: Http.Api.Ibms /api/2.0/ibms/:id "after each" hook for "should get an IBM instance"
Error Details: Cannot read property 'needByIdentifier' of undefined
Stack Trace: TypeError: Cannot read property 'needByIdentifier' of undefined
at Context.<anonymous> (spec/lib/api/2.0/ibms-spec.js:166:27)

Test Name: Ssh Serializable V1 deserialize should not encrypt publicKey fields
Error Details: Cannot read property 'password' of undefined
Stack Trace: TypeError: Cannot read property 'password' of undefined
at SshFactory.Ssh.deserialize (lib/serializables/v1/ssh.js:9:2029)
at Context.<anonymous> (spec/lib/serializables/v1/ssh-spec.js:154:33)

@srinia6
Copy link
Contributor

srinia6 commented Jan 18, 2017

+1

@brianparry brianparry merged commit bfd0260 into RackHD:feature/ibms Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.