-
Notifications
You must be signed in to change notification settings - Fork 77
Windows os regression script enhancement #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows os regression script enhancement #537
Conversation
uppalk1
commented
Nov 18, 2016
- Add firewallDisable to let ping function test the new static IP
after the static IP is set as part of max payload
| <SynchronousCommand wcm:action="add"> | ||
| <Order>2</Order> | ||
| <% if( firewallDisable ) { %> | ||
| <CommandLine>powershell -Command "Set-NetFirewallProfile -Profile Domain,Public,Private -Enabled False" </CommandLine> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need this line and the next line to be enclosed with <% %>, otherwise the firewall is going to be disabled for all installs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geoff-reid I tested otherwise and it stays enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good. I retract my comment.
| </SynchronousCommand> | ||
| <SynchronousCommand wcm:action="add"> | ||
| <Order>2</Order> | ||
| <% if( firewallDisable ) { %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add check for undefined value
|
@geoff-reid firewallDisable defaults to false. If I check for undefined I need to remove the default value or else xml script complains. |
|
BUILD on-http #2856 : UNSTABLE
|
|
test this please... |
geoff-reid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
brianparry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍