-
Notifications
You must be signed in to change notification settings - Fork 77
remove node update based on enclosure node update #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We are testing Travis CI. Since there are no .travis.yml files it will fail. |
lib/services/nodes-api-service.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to make the code in these promise blocks their own named functions, that way we can more easily test their functionality individually, and also have a more easily readable promise chain.
|
test this please |
|
👍 with a suggestion about some potential cleanup. |
ab0d77f to
abb2f20
Compare
|
codes has been refactored and updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an error that I put in a bunch of tests a while back. This statement can actually go in the before block instead of the beforeEach block, since we only need to create the sandbox once (and will save us test execution time).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. most of cases didn't pay attention on this. let's correct it from now. I've also update it
|
Thanks @anhou! Still 👍 |
abb2f20 to
aa9d699
Compare
lib/services/nodes-api-service.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not big problem. the better name is "removeEnclosureRelations" because it cannot be used to remove other future relations.
|
still 👍 , though I have some minor suggestion |
aa9d699 to
7cd96df
Compare
7cd96df to
aad5e10
Compare
remove node update based on enclosure node update
Update removing node based on @iceiilin 's PR RackHD/on-tasks#26