Add proxy support for switch #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 11, 2017
| .set("X-RackHD-API-proxy-ip", "127.0.0.1") | ||
| .set("X-RackHD-API-proxy-port", "7180") | ||
| .expect(200) | ||
| .then(function(res) { |
Member
Author
yyscamper
reviewed
Apr 12, 2017
spec/lib/api/2.0/profiles-spec.js
Outdated
| }); | ||
|
|
||
| describe("2.0 GET /profiles/switch/:vendor", function() { | ||
| it.only("should get switch profile via proxy", function() { |
Contributor
There was a problem hiding this comment.
Remove only! I believe this is the reason of huge coverage lost.
pengz1
force-pushed
the
Add-proxy-support-for-switch
branch
from
fe10cc8 to
c54c378
Compare
iceiilin
approved these changes
Apr 13, 2017
|
|
||
| // GET /api/2.0/profiles/switch/:vendor | ||
| var profilesGetSwitchVendor = controller(function(req, res) { | ||
| var requestIp = req.get("X-Real-IP") || req.connection._peername.address; |
Member
There was a problem hiding this comment.
@RackHD/corecommitters what is req.connection._peername.address?
Contributor
|
test this please |
yyscamper
approved these changes
Apr 14, 2017
Contributor
|
jenkins: test this please |
Contributor
|
test this please |
1 similar comment
Contributor
|
test this please |
Contributor
|
BUILD on-http #92 : FAILURE BUILD on-http #92 Error Logs ▼Test Name: Http.Api.Tasks GET /tasks/:id should return 404 if no active task exists Error Details: expected 404 "Not Found", got 500 "Internal Server Error" Response body: { message: '/home/jenkins/workspace/on-http/build-deps/on-http/data/views:2 1| { >> 2| "identifier": "<%= identifier %>", 3| <% if (hasOwnProperty("exit")) { %> 4| "exit": "<%= exit %>", 5| <% } %> identifier is not defined', status: '500', UUID: 'fa56f785-1fc6-4724-9a72-5da76735171d' } Error: expected 404 "Not Found", got 500 "Internal Server Error" at Test._assertStatus (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: Error: expected 404 "Not Found", got 500 "Internal Server Error" at Test._assertStatus (node_modules/supertest/lib/test.js:232:12) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12) |
Contributor
|
test this please |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prioritize "X-Real-IP" for switch getting profile to support proxy.