Added generate enclosure job #26
Conversation
lib/jobs/generate-enclosure.js
Outdated
There was a problem hiding this comment.
Whether the IPMI spec says the "Builtin FRU device (ID 0)" always maps to the enclosure?
There was a problem hiding this comment.
Good catch.
"Builtin FRU device (ID 0)" is hard coded in ipmitool for FRU 0, so it will also be there as long as we use methods based on ipmitool. and in IPMI spec, FRU device ID 0 is "FRU Device for the FRU that the management controller is located on".
I checked FRU spec in IPMI standard, "Product Serial" is in "product area info" of FRU format. Although our supported platforms support this area and entry, it is optional in the spec, and there is possibility that some vendors won't expose this info.
There are other sources in node's catalog that contains product serial number. I will use ipmi-fru as first source to cover mgmt. server which only have ipmi related info. Add will add dmi sources to cover some nodes which doesn't have this info in ipmi channel.
|
👍 great work! |
|
Smoke test is needed to be modified due to changes in monorail API /nodes (without catalogs). Will get code changes in tests repo reviewed and merged product and test code at the same time. |
|
Note to self: Some comments still pending on https://github.com/RackHD/tests/pull/39, merge this and its dependents when they are resolved. |
…onorail This is a commit depending on on-http pull Request RackHD#26 which adds SAS/SATA controller infomation into the SMART raw output. The change in this commit further decodes the newly added SMART catalog fields and appends them to the SMART catalog. Unit test code is also included
Removing code for hardwired credentials and reading IP from DB
Fix async function usage in task-graph-subscriptions
…master * commit '786c9180ec5ec41394d216100d1f6fde76f6fcaf': Remove unnecessary toJSON that breaks tests on some machines
adding slack notifications
3 participants
Add a generate enclosure job, which can be executed when discovery compute node.
In this job, a node with type "enclosure" will be created; the information about enclosure's SN and compute nodes which are inserted in this enclosure will be added into this node.
The corresponding compute node will also have an array about its enclosure node ID.
https://hwjiraprd01.corp.emc.com/browse/MAG-176
PRs in other repos for this feature:
RackHD/on-taskgraph#11
RackHD/on-core#14
RackHD/on-http#18
@benbp @jfrey @VulpesArtificem