Added generate enclosure task into discovery graph #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2015
Contributor
There was a problem hiding this comment.
SKU generation failure will not impact the enclosure generation, so it requires to add "ignoreFailure: true" in generate-sku task, or move generate-enclosure to be before generate-sku.
In future we may need to define the SKU rule for enclosure.
Member
Author
There was a problem hiding this comment.
The enclosure generation job will be run after discovery succeeded (see waitOn options), parallel with sku generation. So the sku generation doesn't impact enclosure generation.
Contributor
|
👍 |
Contributor
|
👍 |
benbp
added a commit
that referenced
this pull request
Oct 27, 2015
Added generate enclosure task into discovery graph
rahman-muhammad
pushed a commit
that referenced
this pull request
May 8, 2017
…rvice-payload modify post discovery for new service payload
sushilrai
pushed a commit
to sushilrai/on-taskgraph
that referenced
this pull request
Dec 5, 2017
update mock logger
sushilrai
pushed a commit
to sushilrai/on-taskgraph
that referenced
this pull request
Dec 5, 2017
…-cache-fix to master * commit '63c1612d4e7b2dc04069ea0748f4d5e7316d36ea': Fix noop-obm-service power state cacheing to work across instances
sushilrai
pushed a commit
to sushilrai/on-taskgraph
that referenced
this pull request
Dec 5, 2017
fixed undefined workitem bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added generate enclosure task into discovery graph.
https://hwjiraprd01.corp.emc.com/browse/MAG-176
PRs in other repos for this feature:
RackHD/on-tasks#26
RackHD/on-core#14
RackHD/on-http#18
@benbp @jfrey @VulpesArtificem