Skip to content

Added generate enclosure task into discovery graph #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbp merged 2 commits into from
Oct 27, 2015
Merged

Added generate enclosure task into discovery graph #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af22567
Added generate enclosure task into discovery graph
iceiilin Oct 9, 2015
6cbce26
Added generate enclosure job into mgmt server discovery workflow
iceiilin Oct 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/graphs/discovery-mgmtsku-graph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ module.exports = {
},
taskName: 'Task.Catalog.GenerateSku'
},
{
label: 'generate-enclosure',
waitOn: {
'discovery-mgmt-graph': 'succeeded'
},
taskName: 'Task.Catalog.GenerateEnclosure',
ignoreFailure: true
},
{
label: 'create-mgmt-default-pollers',
taskDefinition: {
Expand Down
8 changes: 8 additions & 0 deletions lib/graphs/discovery-sku-graph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ module.exports = {
},
taskName: 'Task.Catalog.GenerateSku'
},
{
label: 'generate-enclosure',
Copy link
Contributor

@yyscamper yyscamper Oct 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SKU generation failure will not impact the enclosure generation, so it requires to add "ignoreFailure: true" in generate-sku task, or move generate-enclosure to be before generate-sku.

In future we may need to define the SKU rule for enclosure.

Copy link
Member Author

@iceiilin iceiilin Oct 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enclosure generation job will be run after discovery succeeded (see waitOn options), parallel with sku generation. So the sku generation doesn't impact enclosure generation.

Copy link
Contributor

@yyscamper yyscamper Oct 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

waitOn: {
'discovery-graph': 'succeeded'
},
taskName: 'Task.Catalog.GenerateEnclosure',
ignoreFailure: true
},
{
label: 'create-default-pollers',
taskDefinition: {
Expand Down