Added enclosure node type #14
Conversation
spec/lib/models/node-spec.js
Outdated
There was a problem hiding this comment.
This can be shorter: expect(this.subject.json).to.be.true, your code is OK as well.
There was a problem hiding this comment.
I've actually gotten used to using expect(...).to.equal(true), the reason being when you do it that way mocha will actually print out the offending value on test failure, whereas expect(...).to.be.true ends up hiding the offending value, making test failures harder to assess after the fact. I wish it wasn't this way, I find the latter more readable/clean.
|
+1 |
lib/models/node.js
Outdated
There was a problem hiding this comment.
I suggest we have this default to an empty array (see the overlapping work we did accidentally here: https://github.com/RackHD/on-core/pull/11/files). Not sure whether we want it as 'json' type or 'array' type, probably json?
There was a problem hiding this comment.
When coding, I wanted to add more flexibility about its contents. But array might be enough from our design. Will change to array.
|
👍 |
added example tools and git submodules
adding coreos install media
switch wsman callback uri to 2.0 api
3 participants
Added enclosure node type.
https://hwjiraprd01.corp.emc.com/browse/MAG-176
PRs in other repos for this feature:
RackHD/on-taskgraph#11
RackHD/on-tasks#26
RackHD/on-http#18
@jfrey @VulpesArtificem @benbp